Improve gym error handling for export archive

lacostej commented 8 years ago

When using gymto export archives, xcodebuild error handling can sometimes be confusing.

By default, all output, standard and error, from the xcodebuild command, is outputted to the standard error (and not colorized). Then gym detects issues and appends an error message. Also, if a particular error happens, e.g. the xcodebuild standard log is now concatenated, also as an error (in RED).

In some cases, this helps: gym 1.2.0 output xcode logs
in others, the concatenated ERROR output doesn't add more information, and can confuse the user, as the real error is printed in BLACK (before "EXPORT FAILED"): gym 1.4.0 output xcode logs

Some ideas:

be a bit smarter at deciding when to concatenate extra output
colorize the xcodebuild output differently (for standard and error outputs?)

KrauseFx commented 8 years ago

Sounds great :+1:

lacostej commented 8 years ago

I looked into coloring the executed output command differently and here are my findings:

PTY.spawn merges stdout and stderr and I don't think there's a way around that.
if we move away from PTY.spawn, e.g. to popen3, we need to be careful at not creating deadlocks (either using threads or using select). Also we might lose some colors (e.g. by default rspec doesn't force coloring on its output for non tty environments).

lacostej commented 8 years ago

Just to take note of this: I push the work on pluggable Runners (to exclude PTYs) before that one). See fastlane/fastlane_core#73

fastlane-bot-helper commented 8 years ago

This issue was migrated to https://github.com/fastlane/fastlane/issues/1826. Please post all further comments there.

fastlane is now a mono repo, you can read more about the change in our blog post. All tools are now available in the fastlane main repo :rocket:

fastlane-old / gym

Improve gym error handling for export archive #192