search

fastlane-old / gym

Building your iOS apps has never been easier
https://fastlane.tools
645 stars 54 forks source link

Fix building tvOS apps #195

Closed tmm1 closed 8 years ago

tmm1 commented 8 years ago

This lets gym build tvos apps

KrauseFx commented 8 years ago

Hey @tmm1, thanks for the PR. Did you test gym with these changes to build tvOS apps? Have you tried submitting an app to the store to see if it passes validation?

tmm1 commented 8 years ago

Yes, submitted through TestFlight without a problem.

The only issue I've noticed is that it looks like all files are rebuilt every time I run gym, even though clean false is set. Not sure if that's expected behavior or some sort of regression with tvos.

KrauseFx commented 8 years ago

@tmm1 Yeah, that's a separate issue with xcodebuild :+1:

tmm1 commented 8 years ago

@tmm1 Yeah, that's a separate issue with xcodebuild

Bummer. Got any links handy?

KrauseFx commented 8 years ago

Could you squash the commits, before I can merge it :+1:

tmm1 commented 8 years ago

Done.

tmm1 commented 8 years ago

Ping.

KrauseFx commented 8 years ago

Sorry for the delay, and thanks for updating the PR @tmm1 :+1:

mgazdich commented 8 years ago

I saw this was merged into master however I am still seeing the "gym doesn't suppoort tvOS projects yet, we're working on adding this feature!". Is there still some development going on for this feature, or is something else wrong, and i should be able to make build for tvOS?

KrauseFx commented 8 years ago

@mgazdich Yeah, I just noticed I haven't pushed a new release in a while, will do that right now :+1:

KrauseFx commented 8 years ago

It's live :rocket: https://github.com/fastlane/gym/releases/tag/1.5.0, thanks again for letting me know @mgazdich :+1:

mgazdich commented 8 years ago

Absolutely! I just ran an update. One little thing I am notice however, is when i have the default platform specified in my fastfile as tvos is gives me the same "doesnt support" error.

Any incite? And if there is a better avenue to communicating with you, by all means. Is there a need to update fastlane at all? Or is just running the gem install for gym enough?

KrauseFx commented 8 years ago

@mgazdich Please submit a separate GitHub issue and share your Fastfile and the complete output when running it :+1: