fastlane-old / gym

Building your iOS apps has never been easier
https://fastlane.tools
645 stars 54 forks source link

adding option to just export ipa from archive_path #222

Closed angu-software closed 8 years ago

angu-software commented 8 years ago

Added an option to only export an ipa file from a xarchive.

For me it is required to export development, adhoc and appstore version of an build. This option enables me to skip two build processes and only export ipas from the same build archive.

angu-software commented 8 years ago

This addresses #12

angu-software commented 8 years ago

Don't know why the build failed. No concrete error was reported from travis. Can someone help? Have no idea.

lacostej commented 8 years ago

Try pushing again :) Sometimes it fails like that.

angu-software commented 8 years ago

Already tried a second time but same result? I looked into the travis output and it hangs just after displaying the help of gym. I'l try a third time... just to be sure ;-)

angu-software commented 8 years ago

Thanks @lacostej . I missed that. But still no success. :sob:

angu-software commented 8 years ago

I think this may be related to #119

angu-software commented 8 years ago

@lacostej Is there a way to run the tests of travis on my own machine? Maybe I can get a hold on the problem.

lacostej commented 8 years ago

@dreyhomedev you could try rake test but it doesn't fail on my machine as the problem is CI related.

It is most probably related to enable_paging in commander

https://github.com/tj/commander/blob/d10fc03ce9d44a0a34bb913df99dded4a0bd5287/lib/commander/user_interaction.rb#L274

The | cat was added just a few days ago by @mfurtak, so maybe he or @KrauseFx knows.

lacostej commented 8 years ago

I sent fastlane/fastlane#1378, maybe that helps

angu-software commented 8 years ago

Thanks a lot @lacostej. I tried to run rake test but since i'm not a ruby dev I'm lacking the ruby environment to run rake. ^^ Is there a complete environment I can install wich contains all needed resources?

I really appreciate your help!

angu-software commented 8 years ago

Hey @lacostej I saw your PR was merged. Do you think i should try again with a new pull? ;-)

lacostej commented 8 years ago

@dreyhomedev a mine didn't work fully so a few more things were tried (e.g. https://github.com/fastlane/fastlane/commit/4226f896fa59e0d5507a5c2dfed2812f24b8d741), so yes I think you can try with a new push.

angu-software commented 8 years ago

YAY!!

angu-software commented 8 years ago

I do not see any conflicts with the current options. It will fail if you do not specify a build archive or the archive is not at the specified path.

To have a new command would also be nice, but i'm not ruby pro enough to implement that :wink: How would one specify it in the Fastfile? Just export?

lacostej commented 8 years ago

For the new command, you need to look at

https://github.com/dreyhomedev/gym/blob/master/lib/gym/commands_generator.rb#L36-L44

But let's see what other think before you do it. Maybe the export parameter is good enough ?

angu-software commented 8 years ago

OK, I'll ask the guys in the issue #12

mokagio commented 8 years ago

Hey @dreyhomedev, great work.

I usually see command line options like --no-xxx in CLIs that allow to modify the standard behaviour. For example CocoaPods pod install provides --no-clean, --no-integrate, and --no-repo-update. Carthage carthage update provides --no-build, --no-checkout, --no-use-binaries. Git git commit provides --no-pager, --no-replace-objects. And so on.

What do you think of the idea of making your option a --no-sign instead?

czechboy0 commented 8 years ago

Also --no-build I think

angu-software commented 8 years ago

@mokagio Thanks for the input. I admit that just_export doesn't sound very professional but I've not seen any option in the fastlane tools that is names like your suggestions. Instead I saw skip_build in scan. I would prefer to name it skip_build_archive to be consistent among the fastlane tools.

How about that?

mpirri commented 8 years ago

@dreyhomedev Looks awesome! Merging. :+1:

czechboy0 commented 8 years ago

:+1: