search

fastlane-old / gym

Building your iOS apps has never been easier
https://fastlane.tools
645 stars 54 forks source link

Added `:archive_name` parameter. #224

Closed bartoszj closed 8 years ago

bartoszj commented 8 years ago

Hi,

Currently, if you want to adjust archive path / name you have to provide full archive path (with the archive name) using :archive_path, or adjust folder path where the archive will be stored using :build_path (without the archive name). If you want to have custom archive name, with e.g. custom date format, or additional characters added to the name, but you don't want to provide the full path that is not possible. Thats is why I've added :archive_name parameter, where user can adjust only the archive name.

KrauseFx commented 8 years ago

Thanks for the PR, what's the use case of having custom archive names?

bartoszj commented 8 years ago

Hi,

In my case, I've added :build_path to my Gymfile, so all builds / lanes are storing xcarchive in the folder that I've provided. But the archive name is not "perfect" for me. By default it contains the :output_name and the time when it was created. In my case, I want the archive name to only contains name without date. Also I want to adjust archive name depending on the lane where the gym is executed. With :archive_name I'm able to provide only the archive name, the folder where archive will be created is already provided by the :build_path. Without :archive_name, I've to provide full path to the xcarchive by using :archive_path. Using :build_path and :archive_name saves me some lines of codes.

mpirri commented 8 years ago

Thanks so much for this PR and your justification for it; unfortunately, we feel as though this is similar enough to what we already have available via a relatively simple path-join of :build_path and archive name to construct an :archive_path.

Please let us know if you have more information for us and we can re-consider/reopen this PR. Thanks again for your time with this!