search

fastlane-old / scan

The easiest way to run tests of your iOS and Mac app
https://fastlane.tools
221 stars 25 forks source link

scan is twice slower on building code #35

Closed yakimant closed 8 years ago

yakimant commented 8 years ago

As I see - the difference between my xcodebuild arguments and scan generated is: I run clean test and scan runs clean build test.

I also see duplicates of compiling lines.

Is it building twice?

tutipeti commented 8 years ago

Any feedback here? I find it funny how fastlane is telling me that it saved me time when I can easily see that scan is compiling twice - so running the tests takes about twice as long as it did when I were using only xcodebuild.

arunks commented 8 years ago

Looks like this is an issue. I tried running the xcodebuild command generated by scan directly without the build option. Just clean test. That seems to have cut the time in half.

KrauseFx commented 8 years ago

@yakimant did you test everything when removing the build part of the command? I'm pretty sure there was a reason this was added to scan a while back, but can't remember why.

attheodo commented 8 years ago

+1 for that. scan takes significantly more because it involves rebuilding the whole thing VS hitting CMD+U on Xcode. clean: false doesn't seem to help.

arunks commented 8 years ago

@KrauseFx I have been using xcodebuild to workaround this problem, instead of Scan. Currently, I am just passing the test command and have seen no issues with it in running our CI.

Also, I compared the execution times of just xcodebuild test from fastlane and using Scan from fastlane. Scan is considerably slower because does a build and test. Hope this helps.

I have a PR, if you think everything's alright - https://github.com/fastlane/scan/pull/62

kdawgwilk commented 8 years ago

I am also seeing not only everything built twice but the tests are being ran twice 😁 Looks like I am going to switch back to xcodebuild till it gets fixed

nikolaykasyanov commented 8 years ago

same here.

kdawgwilk commented 8 years ago

Was able to speed things up thanks to #86 by using gym to build the binary first then run scan with the new skip_build flag and then deploying same binary that was used for the tests 😊 before this change scan would build the app and test and then gym would build again after tests succeeded

KrauseFx commented 8 years ago

Yeah, thanks for updating this issue, this is now implemented with https://github.com/fastlane/scan/pull/86

fastlanebot commented 8 years ago

This issue was migrated to https://github.com/fastlane/fastlane/issues/3353. Please post all further comments there.

fastlane is now a mono repo, you can read more about the change in our blog post. All tools are now available in the fastlane main repo :rocket: