fastlane-old / sigh

Because you would rather spend your time building stuff than fighting provisioning
https://fastlane.tools
959 stars 87 forks source link

Concurrency issue while downloading provisioning #240

Closed bartoszj closed 8 years ago

bartoszj commented 8 years ago

If two processes from different users at the same time try to download the same provisioning profile, then one of the process crash with error:

/usr/local/lib/ruby/gems/2.3.0/gems/sigh-1.2.1/lib/sigh/runner.rb:168:in `initialize': Permission denied @ rb_sysopen - /tmp/AdHoc_*.mobileprovision (Errno::EACCES)
    from /usr/local/lib/ruby/gems/2.3.0/gems/sigh-1.2.1/lib/sigh/runner.rb:168:in `open'
    from /usr/local/lib/ruby/gems/2.3.0/gems/sigh-1.2.1/lib/sigh/runner.rb:168:in `download_profile'
    from /usr/local/lib/ruby/gems/2.3.0/gems/sigh-1.2.1/lib/sigh/runner.rb:50:in `run'
    from /usr/local/lib/ruby/gems/2.3.0/gems/sigh-1.2.1/lib/sigh/manager.rb:7:in `start'
    from /usr/local/lib/ruby/gems/2.3.0/gems/sigh-1.2.1/bin/sigh:36:in `block (2 levels) in run'
    from /usr/local/lib/ruby/gems/2.3.0/gems/commander-4.3.5/lib/commander/command.rb:178:in `call'
    from /usr/local/lib/ruby/gems/2.3.0/gems/commander-4.3.5/lib/commander/command.rb:153:in `run'
    from /usr/local/lib/ruby/gems/2.3.0/gems/commander-4.3.5/lib/commander/runner.rb:428:in `run_active_command'
    from /usr/local/lib/ruby/gems/2.3.0/gems/commander-4.3.5/lib/commander/runner.rb:68:in `run!'
    from /usr/local/lib/ruby/gems/2.3.0/gems/commander-4.3.5/lib/commander/delegates.rb:15:in `run!'
    from /usr/local/lib/ruby/gems/2.3.0/gems/sigh-1.2.1/bin/sigh:91:in `run'
    from /usr/local/lib/ruby/gems/2.3.0/gems/sigh-1.2.1/bin/sigh:109:in `<top (required)>'
    from /usr/local/bin/sigh:23:in `load'
    from /usr/local/bin/sigh:23:in `<main>'

Problem exists because provisioning profile is always downloaded to the same temporary location. I would suggest to save file to unique temporary location.

fastlanebot commented 8 years ago

This issue was migrated to https://github.com/fastlane/fastlane/issues/2863. Please post all further comments there.

fastlane is now a mono repo, you can read more about the change in our blog post. All tools are now available in the fastlane main repo :rocket: