search

fastlane-old / sigh

Because you would rather spend your time building stuff than fighting provisioning
https://fastlane.tools
958 stars 86 forks source link

Invalid command leads to stack trace instead of error #242

Closed niklassaers closed 8 years ago

niklassaers commented 8 years ago

I forgot the parameter "manage" and got a stack trace. I expected an error message:

$ sigh -p "test"
/Library/Ruby/Gems/2.0.0/gems/commander-4.3.5/lib/commander/command.rb:164:in `parse_options_and_call_procs': invalid option: -p (OptionParser::InvalidOption)
    from /Library/Ruby/Gems/2.0.0/gems/commander-4.3.5/lib/commander/command.rb:153:in `run'
    from /Library/Ruby/Gems/2.0.0/gems/commander-4.3.5/lib/commander/runner.rb:428:in `run_active_command'
    from /Library/Ruby/Gems/2.0.0/gems/commander-4.3.5/lib/commander/runner.rb:68:in `run!'
    from /Library/Ruby/Gems/2.0.0/gems/commander-4.3.5/lib/commander/delegates.rb:15:in `run!'
    from /Library/Ruby/Gems/2.0.0/gems/sigh-1.2.1/bin/sigh:91:in `run'
    from /Library/Ruby/Gems/2.0.0/gems/sigh-1.2.1/bin/sigh:109:in `<top (required)>'
    from /usr/local/bin/sigh:23:in `load'
    from /usr/local/bin/sigh:23:in `<main>'
KrauseFx commented 8 years ago

The error message is right there

/Library/Ruby/Gems/2.0.0/gems/commander-4.3.5/lib/commander/command.rb:164:in `parse_options_and_call_procs': invalid option: -p (OptionParser::InvalidOption)
invalid option: -p
niklassaers commented 8 years ago

You're right, it's the part where the stack trace comes in addition that surprised me.

fastlanebot commented 8 years ago

This issue was migrated to https://github.com/fastlane/fastlane/issues/2862. Please post all further comments there.

fastlane is now a mono repo, you can read more about the change in our blog post. All tools are now available in the fastlane main repo :rocket: