search

fastlane-old / sigh

Because you would rather spend your time building stuff than fighting provisioning
https://fastlane.tools
958 stars 86 forks source link

Fix issue with resigning apps with nested watchkit app and extension #266

Closed mgrebenets closed 8 years ago

mgrebenets commented 8 years ago

See #265 for more details Just fixing up CBBundleIdentifier for each nested app or extension is not enough Must also fix references from WatchKit app to companion app and from WatchKit extension to WatchKit app

asfalcone commented 8 years ago

@kommen @baarde Would you mind helping me out by taking a look at this PR? Thanks 🎁

kommen commented 8 years ago

I don't have a WatchKit app at hand where I use resign, so I can't test this PR.

The change looks good to me though.

asfalcone commented 8 years ago

@mgrebenets thanks for the PR! @kommen thanks for the review! :rocket: :watch:

mgrebenets commented 8 years ago

Thanks @kommen @asfalcone :+1:

Since we are at it, I have a few questions with regards to resign.sh. Do you guys know why most, if not all, of the echo commands are writing to stderr via >&2? It's not critical, but CI servers like Team City treat these messages as warnings this way, while the messages are just normal logs.

asfalcone commented 8 years ago

@mgrebenets not sure unfortunately. could you submit this question as an issue and we'll see if we can figure it out? Thanks!

mgrebenets commented 8 years ago

Sure, done https://github.com/fastlane/sigh/issues/268.