Alert management - Githubissues

fastlane-old / snapshot

Automate taking localized screenshots of your iOS app on every device

https://fastlane.tools

1.95k stars 141 forks source link

Alert management #378

Closed maxbritto closed 8 years ago

maxbritto commented 8 years ago

Adds a function to allow automatic dismissal of alerts that prevent actions or snapshots
Calls to the snapshot() function will now wait until all alert have disappeared before taking the screenshot (can be disabled with a boolean parameter on the snapshot() method)

ohayon commented 8 years ago

so this history looks better, but it appears there is a conflict with the merge. if you update your master branch from this repo rather than your fork, you should be able to fix those conflicts locally

vpolouchkine commented 8 years ago

@maxbritto Can you please squash your commits per https://github.com/fastlane/countdown#submit-a-pull-request? Thanks!

vpolouchkine commented 8 years ago

@maxbritto Looks like there are some conflicts, would you mind resolving them and squashing your commits?

https://help.github.com/articles/resolving-a-merge-conflict-from-the-command-line/ http://git-scm.com/book/en/v2/Git-Tools-Rewriting-History

koenpunt commented 8 years ago

I think that this as an extra function is not that useful. You could just simply call addUIInterruptionMonitorWithDescription yourself.

maxbritto commented 8 years ago

The issue with the interruption monitor is that it is not called if you are not trying to do something on the page. If the alert appears just before the snapshot it will be captured and the monitor won't be called. You need to try to touch something on the screen to trigger the monitor and hide the alert

maxbritto commented 8 years ago

Btw I'm sorry I still haven't fixed the commit I had to work on something else and didn't get a chance to look back at this git thing. I will soon.

ohayon commented 8 years ago

no worries @maxbritto! going to close this for now to clear it from open issues. please reopen when you have had a chance to make the necessary changes. thanks!

maxbritto commented 8 years ago

Believe it or not I was in the middle of a Git online course to try to figure this out when you commented and closed it. I think I now understand the basics of git and managing it locally is ok but when trying to publish, rebase, PR, etc...I still doesn't feel like I'm mastering this. Though I managed to create a nice PR with only one commit and no conflicts https://github.com/fastlane/snapshot/pull/454 . Hope this will finally be the one :) Thanks for your help

ohayon commented 8 years ago

no problem! @maxbritto! we can definitely help out if necessary too! let us know if you are still running into trouble!

maxbritto commented 8 years ago

I'm still waiting for someone to review it but I think I got it right. There are some hounds warning ng though

ohayon commented 8 years ago

hey @maxbritto, if you wouldn't mind, could you just clean up some of those hound warnings? some of them are irrelevant, but the white space and the tabs vs spaces ones are important to be fixed for future changes, lastly, if you could squash all the commits down to one, that would be amazing. then just make sure to reopen the PR with the button below! thank you!!

koenpunt commented 8 years ago

@ohwutup there's a new PR: #454, let's move the discussion there :)