search

fastlane-old / snapshot

Automate taking localized screenshots of your iOS app on every device
https://fastlane.tools
1.95k stars 141 forks source link

support for screenshots located within "SubActivities" collections in… #425

Closed jbtrask closed 8 years ago

jbtrask commented 8 years ago

… the plist

please see related issue for details.

KrauseFx commented 8 years ago

Hey @jbtrask, thanks for the PR, this is great. Did you also test this change to work with the example project from this repo?

jbtrask commented 8 years ago

sorry @KrauseFx, missed that step. just ran it and it seems to work fine. is there a particular test suite or snapshot command we should run against the example project? i'm new to contributing and was following instructions in countdown. great process btw :+1:

KrauseFx commented 8 years ago

Awesome, this is perfect, thank you @jbtrask. Glad you like the countdown repo :+1: No other tests required from my side. Thanks again for contributing :rocket: