search

fastlane-old / snapshot

Automate taking localized screenshots of your iOS app on every device
https://fastlane.tools
1.95k stars 140 forks source link

Add options to add photos and videos to a simulator #430

Closed koenpunt closed 8 years ago

koenpunt commented 8 years ago

Which is useful when your app makes use of your photo library, but you don't want to use the stock items available by default on a simulator.

This code does work, but the short options are now just set to something that was available, but should probably be overthought. Maybe there's a way to have an option be an array, without the requirement of a short option?

KrauseFx commented 8 years ago

This looks great, thanks for your contribution. The short codes are fine :+1: Please see my comments before it's ready to be merged. Also, please squash the commits to one after updating the PR.

koenpunt commented 8 years ago

Cool, one last thing, are the add_photos and add_videos option names in line with the others, or would something like simulator_photos/simulator_videos be better?

KrauseFx commented 8 years ago

I'm okay with add_photos :+1:

koenpunt commented 8 years ago

I guess I'm done :)

koenpunt commented 8 years ago

I'm not actually sure if it has to be booted, let me try that

koenpunt commented 8 years ago

Just checked, when not booted the files won't appear, so it's necessary.

KrauseFx commented 8 years ago

What's the status on this? looks like we have a conflict. Did you test this with your project?

koenpunt commented 8 years ago

The conflict is probably because of the merge of the "erase simulator option", because it involved the same files. And yes, I'm using this in a project.

KrauseFx commented 8 years ago

This looks great, could you squash the commits to one before it's ready to be merged. Thanks again for your contribution @koenpunt :rocket:

koenpunt commented 8 years ago

Done :shipit:

KrauseFx commented 8 years ago

Perfect, thanks you @koenpunt :+1: