search

fastlane-old / snapshot

Automate taking localized screenshots of your iOS app on every device
https://fastlane.tools
1.96k stars 141 forks source link

Improved multiprocess support. #453

Closed bartoszj closed 8 years ago

bartoszj commented 8 years ago

Hi,

Currently snapshot stores the "settings" files like the language.txt in the global /tmp folder. Because of this snapshot can be run only by one user at the same time on the Mac. If someone has Continuous Integration server, like Jenkins, and wants to use two user accounts, the "settings" files have to be placed in another directory. I suggest to use per user cache directory (~/Library/Cache). This is what I've done in this pull request.

i2amsam commented 8 years ago

:+1: this is a nice change @bartoszj , I made some comments, could you also bump the check in the update check

bartoszj commented 8 years ago

@i2amsam Hi, All changes should be applied.

i2amsam commented 8 years ago

@bartoszj 💯this looks perfect :+1:, I'm going to make a small change to the update code so it is easy to handle updates of SnapshotHelper.swift, this will be in the next release.

i2amsam commented 8 years ago

@bartoszj arg, there is a merge conflict now, could you rebase on master and then I'll merge it? Thanks!

bartoszj commented 8 years ago

HI @i2amsam, It should be done ;)

i2amsam commented 8 years ago

:rocket: