search

fastlane-old / snapshot

Automate taking localized screenshots of your iOS app on every device
https://fastlane.tools
1.96k stars 141 forks source link

Simulator language not working after update. #469

Closed freynolds closed 8 years ago

freynolds commented 8 years ago

Just updated to 1.9.0 My snapfile has

languages([ "es-ES" ])

And only 1 of the 6 simulators started in Spanish, the rest started in english (although logs indicated the contrary) [14:46:29](------------------------): ------------------------ 14:46:29: --- iPad Pro - es-ES ---

Any ideas on how to solve this?

PD: I imagine that this is related to #449

vpolouchkine commented 8 years ago

I don't believe it's possible to set the language of the simulator (see https://github.com/fastlane/snapshot/issues/365#issuecomment-172638332).

freynolds commented 8 years ago

Yes, @vpolouchkine after some more reading I read that. I was just going to update that with this type of localization NSLocalizedString("Alert Success", tableName: "sdk", comment: "Alert Success") I'm having errors. It's using the english table instead of the spanish one.

jeffreyjackson commented 8 years ago

What file are you using for your localized string? @freynolds

freynolds commented 8 years ago

Base App: Generic.strings SDK: SDK.strings I use submodules to add the sdk to several apps and the sdk has some layouts that have localized strings.

i2amsam commented 8 years ago

@freynolds was this working before and then regressed with the 1.9.0 update?

freynolds commented 8 years ago

@i2amsam I can't be sure, I though so, but now I don't really know...

How can I translate the whole app, all the strings? any idea?

skywinder commented 8 years ago

Seems it's duplicate or related with #440 Have the same issue

jbonsant commented 8 years ago

Same issue here since 1.9.0

i2amsam commented 8 years ago

@jbonsant was this working before and then regressed? What Xcode version are you using? What does your Snapfile have for languages and simulators?

jbonsant commented 8 years ago

Now i'm on 1.10. I implemented it on 1.9 and i'm not sure if it was working or not.

Xcode 7.1.2

devices([ "iPhone 6s", "iPhone 6s Plus", "iPhone 6", "iPhone 6 Plus", "iPhone 5", "iPhone 4s", "iPad Retina", "iPad Pro" ])

languages([ "fr-CA" ])

i2amsam commented 8 years ago

@jbonsant could you clarify the behavior you are seeing (or not seeing) there are a few different issues in these tickets and I want to make sure they are not getting crossed.

jbonsant commented 8 years ago

All the simulators are starting in English although the screenshots are saved in fr-CA folder

i2amsam commented 8 years ago

Hmm, this is odd, @jbonsant could you try with 1.8.0?

gem install snapshot -v 1.8.0
gem uninstall snapshot -v 1.10.0
gem uninstall snapshot -v 1.9.0
snapshot -v && snapshot
jbonsant commented 8 years ago

I fixed my issue.

I was setting up launch arguments in my test file. It was overwriting the ones of Snapshot.

i2amsam commented 8 years ago

Ok, @freynolds could you post the full output from one of your runs?

skywinder commented 8 years ago

@jbonsant which test file?

jbonsant commented 8 years ago

My swift file with the XCTestCase taking the screenshots

fastlane-bot commented 8 years ago

This issue was migrated to https://github.com/fastlane/fastlane/issues/1636. Please post all further comments there.

fastlane is now a mono repo, you can read more about the change in our blog post. All tools are now available in the fastlane main repo :rocket: