search

fastlane-old / spaceship

Ruby library to access the Apple Dev Center and iTunes Connect
https://spaceship.airforce
671 stars 83 forks source link

Try to provide more contextual information when errors are in the response #267

Closed lacostej closed 8 years ago

lacostej commented 8 years ago

The json returned by ITC contains errors at 2 levels: individual fields (e.g. phone numbers of invalid format) and top level (to easily check if an error is there without having to check the whole json file). spaceship only looks at the top level, where context information is lost. This causes issues like #182 or 

[12:35:48]: fastlane finished with errors
Successfully submitted a crash report. If this is a problem with one of the tools specifically,
please submit an issue on GitHub and attach the following number to it: '228f53194b398b02528cca98b8a738bb'
The crash report has been stored locally '/tmp/sentry_228f53194b398b02528cca98b8a738bb.json'
/Library/Ruby/Gems/2.0.0/gems/spaceship-0.21.1/lib/spaceship/tunes/tunes_client.rb:219:in `handle_itc_response': [!] You must provide an answer for this question. (Spaceship::TunesClient::ITunesConnectError)
    from /Library/Ruby/Gems/2.0.0/gems/spaceship-0.21.1/lib/spaceship/tunes/tunes_client.rb:538:in `update_build_trains!'
    from /Library/Ruby/Gems/2.0.0/gems/spaceship-0.21.1/lib/spaceship/tunes/build_train.rb:118:in `update_testing_status!'
    from /Library/Ruby/Gems/2.0.0/gems/pilot-1.4.1/lib/pilot/build_manager.rb:124:in `distribute_build'
    from /Library/Ruby/Gems/2.0.0/gems/pilot-1.4.1/lib/pilot/build_manager.rb:26:in `upload'
    from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.63.1/lib/fastlane/actions/pilot.rb:18:in `run'
    from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.63.1/lib/fastlane/runner.rb:143:in `block (2 levels) in execute_action'
    from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.63.1/lib/fastlane/actions/actions_helper.rb:35:in `execute_action'
    from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.63.1/lib/fastlane/runner.rb:129:in `block in execute_action'
    from /Library/Ruby/Gems/2.0.0/gems/fastlane-1.63.1/lib/fastlane/runner.rb:128:in `chdir'

(hjanuschka [12:41 PM] since one of the recent updates i get this at the end of pilot:)

hjanuschka commented 8 years ago

same as here: https://github.com/fastlane/pilot/issues/156

fastlanebot commented 8 years ago

This issue was migrated to https://github.com/fastlane/fastlane/issues/2017. Please post all further comments there.

fastlane is now a mono repo, you can read more about the change in our blog post. All tools are now available in the fastlane main repo :rocket: