updated tester adding and searching to use new TestFlight API

phaseOne commented 7 years ago

Fixes / will fix #185

googlebot commented 7 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

phaseOne commented 7 years ago

@taquitos Testing with fastlane/fastlane#10937 branch now

googlebot commented 7 years ago

CLAs look good, thanks!

kdawgwilk commented 7 years ago

Let me know if this is ready for me to give it a go and try it out for our team

phaseOne commented 7 years ago

Making one last fix. Should be ready in about 15min

phaseOne commented 7 years ago

good to go! NOTE: If you're testing this, you need to reference the master branch of fastlane/fastlane in your boarding Gemfile. e.g:

gem 'fastlane', github: 'fastlane/fastlane'

kdawgwilk commented 7 years ago

Tried to test this out and got the following error:

#<ArgumentError: A copy of BoardingService has been removed from the module tree but is still active!>
/usr/local/lib/ruby/gems/2.4.0/gems/activesupport-4.2.9/lib/active_support/dependencies.rb:479:in `load_missing_constant'
/usr/local/lib/ruby/gems/2.4.0/gems/activesupport-4.2.9/lib/active_support/dependencies.rb:184:in `const_missing'
/Users/kadenwilkinson/Sources/vivint/apple/streety-ios-alpha/app/services/boarding_service.rb:41:in `add_tester'
/Users/kadenwilkinson/Sources/vivint/apple/streety-ios-alpha/app/controllers/invite_controller.rb:93:in `create_and_add_tester'
/Users/kadenwilkinson/Sources/vivint/apple/streety-ios-alpha/app/controllers/invite_controller.rb:76:in `submit'
/usr/local/lib/ruby/gems/2.4.0/gems/actionpack-4.2.9/lib/action_controller/metal/implicit_render.rb:4:in `send_action'
/usr/local/lib/ruby/gems/2.4.0/gems/actionpack-4.2.9/lib/abstract_controller/base.rb:198:in `process_action'
/usr/local/lib/ruby/gems/2.4.0/gems/actionpack-4.2.9/lib/action_controller/metal/rendering.rb:10:in `process_action'
/usr/local/lib/ruby/gems/2.4.0/gems/actionpack-4.2.9/lib/abstract_controller/callbacks.rb:20:in `block in process_action'
/usr/local/lib/ruby/gems/2.4.0/gems/activesupport-4.2.9/lib/active_support/callbacks.rb:117:in `call'
/usr/local/lib/ruby/gems/2.4.0/gems/activesupport-4.2.9/lib/active_support/callbacks.rb:555:in `block (2 levels) in compile'
/usr/local/lib/ruby/gems/2.4.0/gems/activesupport-4.2.9/lib/active_support/callbacks.rb:505:in `call'
/usr/local/lib/ruby/gems/2.4.0/gems/activesupport-4.2.9/lib/active_support/callbacks.rb:92:in `__run_callbacks__'
/usr/local/lib/ruby/gems/2.4.0/gems/activesupport-4.2.9/lib/active_support/callbacks.rb:778:in `_run_process_action_callbacks'
/usr/local/lib/ruby/gems/2.4.0/gems/activesupport-4.2.9/lib/active_support/callbacks.rb:81:in `run_callbacks'
/usr/local/lib/ruby/gems/2.4.0/gems/actionpack-4.2.9/lib/abstract_controller/callbacks.rb:19:in `process_action'
/usr/local/lib/ruby/gems/2.4.0/gems/actionpack-4.2.9/lib/action_controller/metal/rescue.rb:29:in `process_action'
/usr/local/lib/ruby/gems/2.4.0/gems/actionpack-4.2.9/lib/action_controller/metal/instrumentation.rb:32:in `block in process_action'
/usr/local/lib/ruby/gems/2.4.0/gems/activesupport-4.2.9/lib/active_support/notifications.rb:164:in `block in instrument'
/usr/local/lib/ruby/gems/2.4.0/gems/activesupport-4.2.9/lib/active_support/notifications/instrumenter.rb:20:in `instrument'
/usr/local/lib/ruby/gems/2.4.0/gems/activesupport-4.2.9/lib/active_support/notifications.rb:164:in `instrument'
/usr/local/lib/ruby/gems/2.4.0/gems/actionpack-4.2.9/lib/action_controller/metal/instrumentation.rb:30:in `process_action'
/usr/local/lib/ruby/gems/2.4.0/gems/actionpack-4.2.9/lib/action_controller/metal/params_wrapper.rb:250:in `process_action'
/usr/local/lib/ruby/gems/2.4.0/gems/actionpack-4.2.9/lib/abstract_controller/base.rb:137:in `process'
/usr/local/lib/ruby/gems/2.4.0/gems/actionview-4.2.9/lib/action_view/rendering.rb:30:in `process'
/usr/local/lib/ruby/gems/2.4.0/gems/actionpack-4.2.9/lib/action_controller/metal.rb:196:in `dispatch'
/usr/local/lib/ruby/gems/2.4.0/gems/actionpack-4.2.9/lib/action_controller/metal/rack_delegation.rb:13:in `dispatch'
/usr/local/lib/ruby/gems/2.4.0/gems/actionpack-4.2.9/lib/action_controller/metal.rb:237:in `block in action'
/usr/local/lib/ruby/gems/2.4.0/gems/actionpack-4.2.9/lib/action_dispatch/routing/route_set.rb:74:in `dispatch'
/usr/local/lib/ruby/gems/2.4.0/gems/actionpack-4.2.9/lib/action_dispatch/routing/route_set.rb:43:in `serve'
/usr/local/lib/ruby/gems/2.4.0/gems/actionpack-4.2.9/lib/action_dispatch/journey/router.rb:43:in `block in serve'
/usr/local/lib/ruby/gems/2.4.0/gems/actionpack-4.2.9/lib/action_dispatch/journey/router.rb:30:in `each'
/usr/local/lib/ruby/gems/2.4.0/gems/actionpack-4.2.9/lib/action_dispatch/journey/router.rb:30:in `serve'
/usr/local/lib/ruby/gems/2.4.0/gems/actionpack-4.2.9/lib/action_dispatch/routing/route_set.rb:817:in `call'
/usr/local/lib/ruby/gems/2.4.0/gems/http_accept_language-2.0.5/lib/http_accept_language/middleware.rb:14:in `call'
/usr/local/lib/ruby/gems/2.4.0/gems/rack-1.6.8/lib/rack/etag.rb:24:in `call'
/usr/local/lib/ruby/gems/2.4.0/gems/rack-1.6.8/lib/rack/conditionalget.rb:38:in `call'
/usr/local/lib/ruby/gems/2.4.0/gems/rack-1.6.8/lib/rack/head.rb:13:in `call'
/usr/local/lib/ruby/gems/2.4.0/gems/actionpack-4.2.9/lib/action_dispatch/middleware/params_parser.rb:27:in `call'
/usr/local/lib/ruby/gems/2.4.0/gems/actionpack-4.2.9/lib/action_dispatch/middleware/flash.rb:260:in `call'
/usr/local/lib/ruby/gems/2.4.0/gems/rack-1.6.8/lib/rack/session/abstract/id.rb:225:in `context'
/usr/local/lib/ruby/gems/2.4.0/gems/rack-1.6.8/lib/rack/session/abstract/id.rb:220:in `call'
/usr/local/lib/ruby/gems/2.4.0/gems/actionpack-4.2.9/lib/action_dispatch/middleware/cookies.rb:560:in `call'
/usr/local/lib/ruby/gems/2.4.0/gems/actionpack-4.2.9/lib/action_dispatch/middleware/callbacks.rb:29:in `block in call'
/usr/local/lib/ruby/gems/2.4.0/gems/activesupport-4.2.9/lib/active_support/callbacks.rb:88:in `__run_callbacks__'
/usr/local/lib/ruby/gems/2.4.0/gems/activesupport-4.2.9/lib/active_support/callbacks.rb:778:in `_run_call_callbacks'
/usr/local/lib/ruby/gems/2.4.0/gems/activesupport-4.2.9/lib/active_support/callbacks.rb:81:in `run_callbacks'
/usr/local/lib/ruby/gems/2.4.0/gems/actionpack-4.2.9/lib/action_dispatch/middleware/callbacks.rb:27:in `call'
/usr/local/lib/ruby/gems/2.4.0/gems/actionpack-4.2.9/lib/action_dispatch/middleware/reloader.rb:73:in `call'
/usr/local/lib/ruby/gems/2.4.0/gems/actionpack-4.2.9/lib/action_dispatch/middleware/remote_ip.rb:78:in `call'
/usr/local/lib/ruby/gems/2.4.0/gems/actionpack-4.2.9/lib/action_dispatch/middleware/debug_exceptions.rb:17:in `call'
/usr/local/lib/ruby/gems/2.4.0/gems/web-console-2.3.0/lib/web_console/middleware.rb:28:in `block in call'
/usr/local/lib/ruby/gems/2.4.0/gems/web-console-2.3.0/lib/web_console/middleware.rb:18:in `catch'
/usr/local/lib/ruby/gems/2.4.0/gems/web-console-2.3.0/lib/web_console/middleware.rb:18:in `call'
/usr/local/lib/ruby/gems/2.4.0/gems/actionpack-4.2.9/lib/action_dispatch/middleware/show_exceptions.rb:30:in `call'
/usr/local/lib/ruby/gems/2.4.0/gems/railties-4.2.9/lib/rails/rack/logger.rb:38:in `call_app'
/usr/local/lib/ruby/gems/2.4.0/gems/railties-4.2.9/lib/rails/rack/logger.rb:20:in `block in call'
/usr/local/lib/ruby/gems/2.4.0/gems/activesupport-4.2.9/lib/active_support/tagged_logging.rb:68:in `block in tagged'
/usr/local/lib/ruby/gems/2.4.0/gems/activesupport-4.2.9/lib/active_support/tagged_logging.rb:26:in `tagged'
/usr/local/lib/ruby/gems/2.4.0/gems/activesupport-4.2.9/lib/active_support/tagged_logging.rb:68:in `tagged'
/usr/local/lib/ruby/gems/2.4.0/gems/railties-4.2.9/lib/rails/rack/logger.rb:20:in `call'
/usr/local/lib/ruby/gems/2.4.0/gems/actionpack-4.2.9/lib/action_dispatch/middleware/request_id.rb:21:in `call'
/usr/local/lib/ruby/gems/2.4.0/gems/rack-1.6.8/lib/rack/methodoverride.rb:22:in `call'
/usr/local/lib/ruby/gems/2.4.0/gems/rack-1.6.8/lib/rack/runtime.rb:18:in `call'
/usr/local/lib/ruby/gems/2.4.0/gems/activesupport-4.2.9/lib/active_support/cache/strategy/local_cache_middleware.rb:28:in `call'
/usr/local/lib/ruby/gems/2.4.0/gems/rack-1.6.8/lib/rack/lock.rb:17:in `call'
/usr/local/lib/ruby/gems/2.4.0/gems/actionpack-4.2.9/lib/action_dispatch/middleware/static.rb:120:in `call'
/usr/local/lib/ruby/gems/2.4.0/gems/rack-1.6.8/lib/rack/sendfile.rb:113:in `call'
/usr/local/lib/ruby/gems/2.4.0/gems/railties-4.2.9/lib/rails/engine.rb:518:in `call'
/usr/local/lib/ruby/gems/2.4.0/gems/railties-4.2.9/lib/rails/application.rb:165:in `call'
/usr/local/lib/ruby/gems/2.4.0/gems/rack-1.6.8/lib/rack/content_length.rb:15:in `call'
/usr/local/lib/ruby/gems/2.4.0/gems/puma-3.9.1/lib/puma/configuration.rb:224:in `call'
/usr/local/lib/ruby/gems/2.4.0/gems/puma-3.9.1/lib/puma/server.rb:602:in `handle_request'
/usr/local/lib/ruby/gems/2.4.0/gems/puma-3.9.1/lib/puma/server.rb:435:in `process_client'
/usr/local/lib/ruby/gems/2.4.0/gems/puma-3.9.1/lib/puma/server.rb:299:in `block in run'
/usr/local/lib/ruby/gems/2.4.0/gems/puma-3.9.1/lib/puma/thread_pool.rb:120:in `block in spawn_thread'
  Rendered invite/index.html.erb within layouts/application (0.2ms)
Completed 200 OK in 56ms (Views: 54.3ms)

phaseOne commented 7 years ago

@kdawgwilk I received that error as well, but only if I didn't run bundle update and restart rails after switching branches. However, that might have been a coincidence.

andydrizen commented 7 years ago

I'm seeing an error in fastlane 2.66 owing to

if tester.kind_of?(Spaceship::Tunes::Tester::Internal)

The error is:

Something went wrong, please contact the application owner: uninitialized constant Spaceship::Tunes::Tester

taquitos commented 7 years ago

@andydrizen thanks, fixed in https://github.com/fastlane/boarding/pull/193

fastlane / boarding

updated tester adding and searching to use new TestFlight API #187