fastlane / boarding

Instantly create a simple signup page for TestFlight beta testers
https://fastlane.tools
MIT License
876 stars 191 forks source link

Fix tests and use web-console for dev only #196

Closed nicolasleger closed 6 years ago

nicolasleger commented 6 years ago

Avoiding the error below when running bundle exec rake :

Web Console is activated in the test environment, which is
usually a mistake. To ensure it's only activated in development
mode, move it to the development group of your Gemfile:

    gem 'web-console', group: :development

If you still want to run it the test environment (and know
what you are doing), put this in your Rails application
configuration:

    config.web_console.development_only = false
googlebot commented 6 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


nicolasleger commented 6 years ago

I signed it!

googlebot commented 6 years ago

CLAs look good, thanks!