search

fastlane / boarding

Instantly create a simple signup page for TestFlight beta testers
https://fastlane.tools
MIT License
876 stars 191 forks source link

updated dependency version to support latest AppStore Connect APIs #229

Closed suculent closed 6 years ago

suculent commented 6 years ago

Thanks, however this is more like a workaround. It does not seem to automatically take new versions in account... such fix should be done a way it won’t be needed next time.

Odesláno z iPhonu

    1. 2018 v 19:15, Felix Krause notifications@github.com:

@KrauseFx approved this pull request.

Perfect, thanks for your contribution @suculent 👍

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

KrauseFx commented 6 years ago

Thanks @suculent, can you tell us more about how this would be possible by submitting a new issue? From what I understand, Heroku will always use the Gemfile.lock, so we'll have to always update it

suculent commented 6 years ago

I don't see a simple way through this. Gemfile.lock will be always recreated by pre-commit heroku hooks. Deleting it using another hook forcefully would cause much more unpredictable issues.

Only a continuous integration system, that would periodically check dependency changes (updates) and automatically create new builds on such changes handsfree, running tests (if any) and pushing new version when passed to this very repo would solve it (without bothering you with a PR).

@suculant aka Matej Sychra

    1. 2018 v 19:36, Felix Krause notifications@github.com:

Thanks @suculent, can you tell us more about how this would be possible by submitting a new issue? From what I understand, Heroku will always use the Gemfile.lock, so we'll have to always update it

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

KrauseFx commented 6 years ago

Yah that makes sense. So we'll leave it as is for now then