Discrepancy in documentation around match revoke requirement

fastlane / docs

All the fastlane docs

https://docs.fastlane.tools

316 stars 521 forks source link

Discrepancy in documentation around match revoke requirement #1240

Open davunderscorei opened 6 months ago

davunderscorei commented 6 months ago

There's this line within Docs » Codesigning » Getting Started

https://github.com/fastlane/docs/blob/c5491f408fab0e8080d72ca6345fff73854fe6cf/docs/codesigning/getting-started.md?plain=1#L23

Is this still the case? I don't see any reference to this fact within https://docs.fastlane.tools/actions/match/ or https://codesigning.guide/.

If this is no longer the case this line should be updated
If this is still a requirement then this should be made more clear within the match documentation

rogerluan commented 3 months ago

Nice catch! I think you're right, we don't need that line in the getting started page anymore. I don't recall that being a hard requirement (not anymore, at least). However, it's much easier/cleaner/simpler if you do revoke all the existing certs and profiles, just to start from scratch and keep everything clean 😅 maybe we could have that different way to phrase it in both pages?

If you're keen to open a PR, I'd gladly review it 🤗