search

fastlane / fastfile-parser

Convert the Fastfile to a JSON file
https://fastlane.tools
MIT License
7 stars 5 forks source link

gemify for vendoring #9

Closed snatchev closed 6 years ago

snatchev commented 6 years ago

adding .gemspec so that this can be vendored by bundler in ci

https://github.com/fastlane/ci/pull/345

This gem is not intended to be publicly distributed yet.

googlebot commented 6 years ago

So there's good news and bad news.

:thumbsup: The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

:confused: The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

KrauseFx commented 6 years ago

Nice! we haven't yet decided though if we want to distribute this as a gem, as part of the fastlane gem (mono gem after all) or as part of fastlane.ci :)

snatchev commented 6 years ago

@KrauseFx even if we pull this into the source tree of fastlane.ci, I think it's valuable to manage the dependency via bundler. Updated with like to PR in ci.