fastlane-bot
commented
8 years ago
|
@KrauseFx commented |
setupSnapshot should only be called from within UI Tests, it should never be loaded from your actual source code
Closed fastlane-bot closed 8 years ago
fastlane-bot
commented
8 years ago |
|
@KrauseFx commented |
setupSnapshot should only be called from within UI Tests, it should never be loaded from your actual source code
fastlane-bot
commented
8 years ago
|
@brentdur commented |
But if UI Tests are run from Xcode rather then from the snapshot cli, setupSnapshot is still executed, meaning the launch args are still set (including FASTLANE_SNAPSHOT)
fastlane-bot
commented
8 years ago There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates.
Please make sure to update to the latest fastlane version and check if that solves the issue. Let us know if that works for you by adding a comment :+1:
fastlane-bot
commented
8 years ago This issue will be auto-closed because there hasn't been any activity for a few months. Feel free to open a new one if you still experience this problem 👍
yanndupuy
commented
8 years ago This message was created automatically by mail delivery software.
A message that you sent could not be delivered to one or more of its recipients. This is a temporary error. The following address(es) deferred:
dupuyyann@gmail.com Domain zyapps.com has exceeded the max emails per hour (400/400 (100%)) allowed. Message will be reattempted later
------- This is a copy of the message, including all the headers. ------
Received: from o4.sgmail.github.com ([192.254.112.99]:27511)
by serveur.ex2-p10.com with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128)
(Exim 4.87)
(envelope-from bounces+848413-8f06-yann.dupuy=zyapps.com@sgmail.github.com)
id 1bEKqP-002kVQ-F6
for yann.dupuy@zyapps.com; Sat, 18 Jun 2016 20:19:51 +0200
DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=github.com;
h=from:reply-to:to:cc:in-reply-to:references:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe;
s=s20150108; bh=AS6Ar3zLN9TFMcixjMukkbL3HJk=; b=wJcVBsSEXOBAR20F
BFXZA0dYIXgajAKnCMcM4JIFGEJu7C2sv2XKpDOGvYb1Jqpl40wRlzQw0b06YmsW
n+khnfdO7tVsGcwLoaz5LmSvasOocjJYjviB2+1QKRzs6myi0NMmsRgpCsiY0awg
Y9CzMOBCZ8l4xjZi7FC9cCoiVl4=
Received: by filter0554p1mdw1.sendgrid.net with SMTP id filter0554p1mdw1.8443.5765909523
2016-06-18 18:19:01.291970973 +0000 UTC
Received: from github-smtp2a-ext-cp1-prd.iad.github.net (github-smtp2a-ext-cp1-prd.iad.github.net [192.30.253.16])
by ismtpd0002p1iad1.sendgrid.net (SG) with ESMTP id IsfRp2TeTW6mcJ5GrS0Vzw
for yann.dupuy@zyapps.com; Sat, 18 Jun 2016 18:19:01.217 +0000 (UTC)
Date: Sat, 18 Jun 2016 11:19:01 -0700
From: fastlane bot notifications@github.com
Reply-To: fastlane/fastlane reply@reply.github.com
To: fastlane/fastlane fastlane@noreply.github.com
Cc:
Message-ID: fastlane/fastlane/issue/1641/issue_event/696784290@github.com
In-Reply-To: fastlane/fastlane/issues/1641@github.com
References: fastlane/fastlane/issues/1641@github.com
Subject: Re: [fastlane/fastlane] launch arguments text file persists after run
(#1641)
Mime-Version: 1.0
Content-Type: multipart/alternative;
boundary="--==_mimepart_5765909523a19_5e863ffab96c129c5573bf";
charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Sender: fastlane-bot
X-GitHub-Recipient: yanndupuy
List-ID: fastlane/fastlane
Content preview: Closed #1641. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/fastlane/fastlane/issues/1641#event-696784290 [...]
Content analysis details: (-2.8 points, 5.0 required)
pts rule name description
-2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, medium trust [192.254.112.99 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [192.254.112.99 listed in wl.mailspike.net] -1.4 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain 0.0 HTML_MESSAGE BODY: HTML included in message 1.0 HTML_IMAGE_ONLY_16 BODY: HTML: images with 1200-1600 bytes of words -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-Spam-Flag: NO
----==_mimepart_5765909523a19_5e863ffab96c129c5573bf Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit
Closed #1641.
You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/fastlane/fastlane/issues/1641#event-696784290 ----==_mimepart_5765909523a19_5e863ffab96c129c5573bf Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit
Closed #1641.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
----==_mimepart_5765909523a19_5e863ffab96c129c5573bf--
I'm not sure if there's anything preventing the launch-args file (/tmp/snapshot-launch_arguments.txt) from being deleted after snapshot finishes. But if the file was created at the beginning of tests and removed at the end (much like /tmp/snapshot_derived) then the existence of the file could be use as the condition for whether FASTLANE_SNAPSHOT is set in the
setupSnapshotmethod. (#404)Doing this would also prevent
setupSnapshotfrom setting launch args that were used for running snapshot from being set when the tests are run outside of snapshot. Right now, if I set launch arguments to run with snapshot, and then run the tests from Xcode,setupSnapshotsets those launch arguments again when the developer may not want them to persist. So I feel like having this file removed when snapshot finishes would solve both of these problems