[action] [upload_to_app_store] upload_to_app_store fails without uses_idfa field

Peter-Nagy commented 2 years ago

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I read the Contribution Guidelines
[x] I read docs.fastlane.tools
[x] I searched for existing GitHub issues

Issue Description

When running upload_to_app_store it checks if you have specified the uses_idfa parameter. However, this parameter is deprecated (see here), it has been replaced with the new app privacy details (upload_app_privacy_details_to_app_store and here). upload_to_app_store should not fail because of not using a deprecated parameter, however, I would keep it optional until Apple completely removes it, to keep it more backward compatible.

The bug is caused by this code: https://github.com/fastlane/fastlane/blob/37a14de56460bd9fc9eeff9259872063e91f9e31/deliver/lib/deliver/submit_for_review.rb#L115 I'm happy to take care of this if you agree keeping it as an optional parameter and marking it as deprecated is feasible.

Command executed

upload_to_app_store(
  submit_for_review: true,
  automatic_release: false,
  skip_metadata: true,
  skip_screenshots: true,
  skip_binary_upload: true,
  phased_release: true
)

Complete output when running fastlane, including the stack trace and command used

 [16:46:19]: Selecting the latest build...
[16:46:19]: Waiting for processing on... app_id: 1436140272, app_version: , build_version: , platform: IOS
[16:46:19]: Searching for the latest build
[16:47:31]: Successfully finished processing the build 4.0.18 - 4.0.18.0 for IOS
[16:47:31]: Selecting build 4.0.18 (4.0.18.0)...
[16:47:33]: Successfully selected build
+------------------+------------+
|         Lane Context          |
+------------------+------------+
| DEFAULT_PLATFORM | ios        |
| PLATFORM_NAME    | ios        |
| LANE_NAME        | ios kecske |
+------------------+------------+
[16:47:36]: Use of Advertising Identifier (IDFA) is required to submit
Add information to the :submission_information option...
  Docs: http://docs.fastlane.tools/actions/deliver/#compliance-and-idfa-settings
  Example: submission_information: { add_id_info_uses_idfa: false }
  Example: submission_information: {
    add_id_info_uses_idfa: true,
    add_id_info_serves_ads: false,
    add_id_info_tracks_install: true,
    add_id_info_tracks_action: true,
    add_id_info_limits_tracking: true
  }
  Example CLI:
    --submission_information "{\"add_id_info_uses_idfa\": false}"

+------+------------------+-------------+
|           fastlane summary            |
+------+------------------+-------------+
| Step | Action           | Time (in s) |
+------+------------------+-------------+
| 1    | default_platform | 0           |
| 💥   | deliver          | 182         |
+------+------------------+-------------+

[16:47:36]: fastlane finished with errors

[!] Use of Advertising Identifier (IDFA) is required to submit
Add information to the :submission_information option...
  Docs: http://docs.fastlane.tools/actions/deliver/#compliance-and-idfa-settings
  Example: submission_information: { add_id_info_uses_idfa: false }
  Example: submission_information: {
    add_id_info_uses_idfa: true,
    add_id_info_serves_ads: false,
    add_id_info_tracks_install: true,
    add_id_info_tracks_action: true,
    add_id_info_limits_tracking: true
  }
  Example CLI:
    --submission_information "{\"add_id_info_uses_idfa\": false}"

Environment

 🚫 fastlane environment 🚫

### Stack

| Key                         | Value                                                                   |
| --------------------------- | ----------------------------------------------------------------------- |
| OS                          | 11.6                                                                    |
| Ruby                        | 2.7.2                                                                   |
| Bundler?                    | true                                                                    |
| Git                         | git version 2.33.0                                                      |
| Installation Source         | ~/<...>/vendor/bundle/ruby/2.7.0/bin/fastlane |
| Host                        | macOS 11.6 (20G165)                                                     |
| Ruby Lib Dir                | ~/.rbenv/versions/2.7.2/lib                                             |
| OpenSSL Version             | OpenSSL 1.1.1i  8 Dec 2020                                              |
| Is contained                | false                                                                   |
| Is homebrew                 | false                                                                   |
| Is installed via Fabric.app | false                                                                   |
| Xcode Path                  | /Applications/Xcode-12.5.1.app/Contents/Developer/                      |
| Xcode Version               | 12.5.1                                                                  |
| Swift Version               | 5.4.2                                                                   |

### System Locale

| Error                       |
| --------------------------- |
| No Locale with UTF8 found 🚫 |

### fastlane files:

`./fastlane/Fastfile`

```ruby

platform :ios do
  desc "Submit for review"
  lane :kecske do
    # Send to review
    deliver(
      submit_for_review: true,
      automatic_release: false,
      # force: true, # Skip HTMl report verification
      skip_metadata: true,
      skip_screenshots: true,
      skip_binary_upload: true,
      phased_release: true
    )
  end
end
```


`./fastlane/Appfile`

```ruby
apple_id "<...>"
git_url "<...>"
git_url_cert "<...>"
path "<...>.xcodeproj"
project "<...>.xcodeproj"
team_id "<...>"
workspace "<...>.xcworkspace"

```


### fastlane gems

| Gem      | Version | Update-Status |
| -------- | ------- | ------------- |
| fastlane | 2.197.0 | ✅ Up-To-Date  |

### Loaded fastlane plugins:

| Plugin                                    | Version | Update-Status |
| ----------------------------------------- | ------- | ------------- |
| fastlane-plugin-firebase_app_distribution | 0.3.1   | ✅ Up-To-Date  |
| fastlane-plugin-test_center               | 3.15.3  | ✅ Up-To-Date  |

Loaded gems

| Gem                                       | Version      |
| ----------------------------------------- | ------------ |
| did_you_mean                              | 1.4.0        |
| bundler                                   | 2.1.4        |
| uri                                       | 0.10.0       |
| rake                                      | 13.0.6       |
| rexml                                     | 3.2.5        |
| CFPropertyList                            | 3.0.4        |
| public_suffix                             | 4.0.6        |
| addressable                               | 2.8.0        |
| artifactory                               | 3.0.15       |
| atomos                                    | 0.1.3        |
| aws-eventstream                           | 1.2.0        |
| aws-partitions                            | 1.518.0      |
| aws-sigv4                                 | 1.4.0        |
| jmespath                                  | 1.4.0        |
| aws-sdk-core                              | 3.121.3      |
| aws-sdk-kms                               | 1.50.0       |
| aws-sdk-s3                                | 1.104.0      |
| babosa                                    | 1.0.4        |
| claide                                    | 1.0.3        |
| colored                                   | 1.2          |
| colored2                                  | 3.1.2        |
| colorize                                  | 0.8.1        |
| highline                                  | 2.0.3        |
| commander                                 | 4.6.0        |
| declarative                               | 0.0.20       |
| digest-crc                                | 0.6.4        |
| unf_ext                                   | 0.0.8        |
| unf                                       | 0.1.4        |
| domain_name                               | 0.5.20190701 |
| dotenv                                    | 2.7.6        |
| emoji_regex                               | 3.2.3        |
| excon                                     | 0.87.0       |
| faraday-em_http                           | 1.0.0        |
| faraday-em_synchrony                      | 1.0.0        |
| faraday-excon                             | 1.1.0        |
| faraday-httpclient                        | 1.0.1        |
| faraday-net_http                          | 1.0.1        |
| faraday-net_http_persistent               | 1.2.0        |
| faraday-patron                            | 1.0.0        |
| faraday-rack                              | 1.0.0        |
| multipart-post                            | 2.0.0        |
| ruby2_keywords                            | 0.0.5        |
| faraday                                   | 1.8.0        |
| http-cookie                               | 1.0.4        |
| faraday-cookie_jar                        | 0.0.7        |
| faraday_middleware                        | 1.2.0        |
| fastimage                                 | 2.2.5        |
| gh_inspector                              | 1.1.3        |
| jwt                                       | 2.3.0        |
| memoist                                   | 0.16.2       |
| multi_json                                | 1.15.0       |
| os                                        | 1.1.1        |
| signet                                    | 0.16.0       |
| googleauth                                | 1.0.0        |
| httpclient                                | 2.8.3        |
| mini_mime                                 | 1.1.2        |
| trailblazer-option                        | 0.1.1        |
| uber                                      | 0.1.0        |
| representable                             | 3.1.1        |
| retriable                                 | 3.1.2        |
| webrick                                   | 1.7.0        |
| google-apis-core                          | 0.4.1        |
| google-apis-androidpublisher_v3           | 0.12.0       |
| google-apis-playcustomapp_v1              | 0.5.0        |
| google-apis-iamcredentials_v1             | 0.7.0        |
| google-apis-storage_v1                    | 0.8.0        |
| google-cloud-env                          | 1.5.0        |
| google-cloud-errors                       | 1.2.0        |
| google-cloud-core                         | 1.6.0        |
| google-cloud-storage                      | 1.34.1       |
| json                                      | 2.6.0        |
| mini_magick                               | 4.11.0       |
| naturally                                 | 2.2.1        |
| optparse                                  | 0.1.1        |
| plist                                     | 3.6.0        |
| rubyzip                                   | 2.3.2        |
| security                                  | 0.1.3        |
| simctl                                    | 1.6.8        |
| terminal-notifier                         | 2.0.0        |
| unicode-display_width                     | 1.8.0        |
| terminal-table                            | 1.8.0        |
| tty-screen                                | 0.8.1        |
| tty-cursor                                | 0.7.1        |
| tty-spinner                               | 0.9.3        |
| word_wrap                                 | 1.0.0        |
| nanaimo                                   | 0.3.0        |
| xcodeproj                                 | 1.21.0       |
| rouge                                     | 2.0.7        |
| xcpretty                                  | 0.3.0        |
| xcpretty-travis-formatter                 | 1.0.1        |
| fastlane-plugin-firebase_app_distribution | 0.3.1        |
| trainer                                   | 0.9.1        |
| xctest_list                               | 1.2.1        |
| fastlane-plugin-test_center               | 3.15.3       |


*generated on:* **2021-10-22**

fastlane-bot commented 2 years ago

It seems like you have not included the output of fastlane env To make it easier for us help you resolve this issue, please update the issue to include the output of fastlane env :+1:

Peter-Nagy commented 2 years ago

Updated the issue with fastlane env output.

fastlane-bot commented 2 years ago

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates.

Please make sure to update to the latest fastlane version and check if that solves the issue. Let us know if that works for you by adding a comment :+1:

Friendly reminder: contributions are always welcome! Check out CONTRIBUTING.md for more information on how to help with fastlane and feel free to tackle this issue yourself :muscle:

This issue will be auto-closed if there is no reply within 1 month.

fastlane-bot commented 2 years ago

This issue will be auto-closed because there hasn't been any activity for a few months. Feel free to open a new one if you still experience this problem :+1:

fastlane / fastlane