search

fastlane / frameit-frames

Hosting the latest frameit frames via GitHub Pages
https://fastlane.tools
97 stars 39 forks source link

[hotfix] add missing frames for iPad Pro 12.9-inch (2nd generation) #17

Closed jhandguy closed 3 years ago

jhandguy commented 3 years ago

The frames for the iPad Pro 12.9-inch (2nd generation) seem to have been removed in the previous version (1607001240) although still present in the offsets.json file.

This PR brings those back as App Store Connect still requires screenshots from the iPad Pro 12.9-inch (2nd generation) to be uploaded.

Fixes https://github.com/fastlane/frameit-frames/issues/18

jhandguy commented 3 years ago

Hi @joshdholtz, anything I can do to help move this PR forward? Do you maybe need some clarification on the issue?

joshdholtz commented 3 years ago

@jhandguy Oops sorry! Looking now 😊

edwinveger commented 3 years ago

FYI Changes in this PR appear to have been overridden in a subsequent commit. The App Store requires iPad Pro 2nd gen screenshots and I had to supply "device_frame_version": "1607001240" in my Framefile.json to get frameit to recognize my images.