fastlane / frameit-frames

Hosting the latest frameit frames via GitHub Pages
https://fastlane.tools
97 stars 39 forks source link

Request For October 2021 Apple Devices #25

Open dweekly opened 3 years ago

dweekly commented 3 years ago

Hey folks! Thanks for an awesome product.

I realize these new devices are just making their way out into the field, so I'm sure someone's already on it, but I didn't see a formal Issue request logged for this yet, so here it is:

dweekly commented 3 years ago

Ah, it looks like these devices are not yet available from https://facebook.design/devices which is the origin of these.

sathoeni commented 2 years ago

The iPhone 13 device frames are now available. I've added them in Pull Request #27

dweekly commented 2 years ago

Superb! Thank you! Looks like we will have to wait separately for Facebook (err, Meta) to update iPad Mini 2021 and iPad 2021.

mgrider commented 2 years ago

This issue seems... closable.

I think maybe this should be a separate issue, but my guess is that the iPhone SE (3rd Generation) is too new to be included in this repo. My evidence is that it's not working for me to run fastlane run frameit in a folder containing a screenshot of that simulator. I get the following message:

[17:25:20]: Unsupported screen size [1125, 2001] for path './testPage2.iPhoneSE3rdGen.png'