fastlane / frameit-frames

Hosting the latest frameit frames via GitHub Pages
https://fastlane.tools
97 stars 39 forks source link

Can't frame with Surface Pro device frames using fastlane frameit --force_device_type "Surface Pro X Black" #32

Open arcadius opened 1 year ago

arcadius commented 1 year ago
fastlane frameit --force_device_type "Surface Pro X Black"
[✔] 🚀 
[20:07:13]: Get started using a Gemfile for fastlane https://docs.fastlane.tools/getting-started/ios/setup/#use-a-gemfile
[20:07:14]: Error setting value 'Surface Pro X Black' for option 'force_device_type'

[!] Invalid device type 'Surface Pro X Black'. 
Available values: iPad 10.2, iPad Air 2, iPad Air (2019), iPad Mini 4, iPad Mini (2019), iPad Pro, 
iPad Pro (12.9-inch) (3rd generation), iPad Pro (12.9-inch) (4th generation), 
iPad Pro (10.5-inch), iPad Pro (11-inch), 
Google Pixel 3, Google Pixel 3 XL, Google Pixel 4, 
Google Pixel 4 XL, Google Pixel 5, HTC One A9, HTC One M8, Huawei P8, Motorola Moto E,
 Motorola Moto G, Nexus 4, Nexus 5X, Nexus 6P, Nexus 9, Samsung Galaxy Grand Prime, 
Samsung Galaxy Note 5, Samsung Galaxy Note 10, Samsung Galaxy Note 10+, 
Samsung Galaxy S Duos, Samsung Galaxy S3, Samsung Galaxy S5, Samsung Galaxy S7, 
Samsung Galaxy S8, Samsung Galaxy S9, Samsung Galaxy S10, Samsung Galaxy S10+, 
Xiaomi Mi Mix Alpha, iPhone 5s, iPhone 5c, iPhone SE, iPhone 6s, iPhone 6s Plus, 
MacBook, iPhone 7, iPhone 7 Plus, iPhone 8, iPhone 8 Plus, iPhone X, iPhone XS, 
iPhone XR, iPhone XS Max, iPhone 11, iPhone 11 Pro, iPhone 11 Pro Max, 
iPhone 12, iPhone 12 Pro, iPhone 12 Pro Max, iPhone 12 Mini, iPhone 13, 
iPhone 13 Pro, iPhone 13 Pro Max, iPhone 13 Mini

There are 2 Surface Pro devices in the list at https://github.com/fastlane/frameit-frames/tree/gh-pages/latest

It seems there is no matching code in https://github.com/fastlane/fastlane/blob/master/frameit/lib/frameit/device_types.rb ? Note that I am new to fastlane... maybe I am missing something?

Thanks