search

fastlane / frameit-frames

Hosting the latest frameit frames via GitHub Pages
https://fastlane.tools
95 stars 38 forks source link

12.9-inch iPad Pro (3rd Gen) is missing #7

Open appcornerit opened 5 years ago

appcornerit commented 5 years ago

Hi, Apple metadata rejected due 12.9-inch iPad Pro screenshots do not display the app in the correct device frame, iPad Pro (3rd Gen) doesn't have the home button. Is there a way to force the device frame by Apple? Thanks.

janpio commented 5 years ago

12.9-inch iPad Pro (3rd Gen) is missing

Yes, that device is unfortunately not present with the device frames this is using: https://facebook.design/devices

For your other question(s), you should open an issue at https://github.com/fastlane/fastlane/issues

myice92 commented 5 years ago

Same issue. Hope for alternative solution soon.

ConfusedVorlon commented 5 years ago

temporary workaround:

add this section to ~/.frameit/../latest/offsets.json

    "iPad Pro (12.9-inch) (3rd generation)": {
      "offset": "+119+216",
      "width": 2048
    },

add this frame in ~/.frameit/../latest/Apple iPad Pro (12.9-inch) (3rd generation) Space Gray.png

Apple iPad Pro (12 9-inch) (3rd generation) Space Gray

myice92 commented 5 years ago

temporary workaround:

add this section to ~/.frameit/../latest/offsets.json

    "iPad Pro (12.9-inch) (3rd generation)": {
      "offset": "+119+216",
      "width": 2048
    },

add this frame in ~/.frameit/../latest/Apple iPad Pro (12.9-inch) (3rd generation) Space Gray.png

Apple iPad Pro (12 9-inch) (3rd generation) Space Gray

This is awesome! Thank you so much!

RobertSasak commented 5 years ago

Automate

curl https://user-images.githubusercontent.com/586910/59685084-413aa480-91d3-11e9-9d1f-2c943317f650.png -o ~/.fastlane/frameit/latest/Apple\ iPad\ Pro\ \(12.9-inch\)\ \(3rd\ generation\)\ Space\ Gray.png
# I use WHITE, so I had to add Silver as well while it is the same
# let me know if you have a white frame
curl https://user-images.githubusercontent.com/586910/59685084-413aa480-91d3-11e9-9d1f-2c943317f650.png -o ~/.fastlane/frameit/latest/Apple\ iPad\ Pro\ \(12.9-inch\)\ \(3rd\ generation\)\ Silver.png
# Remove last two lines
sed -i '' -e '$ d' ~/.fastlane/frameit/latest/offsets.json
sed -i '' -e '$ d' ~/.fastlane/frameit/latest/offsets.json
cat >> ~/.fastlane/frameit/latest/offsets.json <<EOL
    ,
      "iPad Pro (12.9-inch) (3rd generation)": {
      "offset": "+119+216",
      "width": 2048
    }
  }
}
EOL
Kylmakalle commented 4 years ago

If you don't need this black line (home slider) or has screenshots in landscape mode, you can use latest (29 sept 2019) device mockups from Facebook. Offset was adjusted and looks fine for me, but i'm not sure it's pixel accurate

Mockups (Space Gray & Silver) ![Apple iPad Pro (12 9-inch) (3rd generation) Space Gray](https://user-images.githubusercontent.com/24507532/66273840-689ba700-e880-11e9-95e6-7ecb63728b2c.png) ![Apple iPad Pro (12 9-inch) (3rd generation) Silver](https://user-images.githubusercontent.com/24507532/66273839-66394d00-e880-11e9-85cf-50f4dc0210c5.png) 
curl https://user-images.githubusercontent.com/24507532/66273840-689ba700-e880-11e9-95e6-7ecb63728b2c.png -o ~/.fastlane/frameit/latest/Apple\ iPad\ Pro\ \(12.9-inch\)\ \(3rd\ generation\)\ Space\ Gray.png
curl https://user-images.githubusercontent.com/24507532/66273839-66394d00-e880-11e9-85cf-50f4dc0210c5.png -o ~/.fastlane/frameit/latest/Apple\ iPad\ Pro\ \(12.9-inch\)\ \(3rd\ generation\)\ Silver.png

# Remove last two lines
sed -i '' -e '$ d' ~/.fastlane/frameit/latest/offsets.json
sed -i '' -e '$ d' ~/.fastlane/frameit/latest/offsets.json
cat >> ~/.fastlane/frameit/latest/offsets.json <<EOL
    ,
      "iPad Pro (12.9-inch) (3rd generation)": {
      "offset": "+200+200",
      "width": 2048
    }
  }
}
EOL
lucashoeft commented 4 years ago

When the 3rd Gen iPad Pro is added to facebook device library , it could be also properly integrated into fastlane frameit, because fastlane is using this device library. The new iPhones could be added as well!

JulesMoorhouse commented 4 years ago

@ConfusedVorlon where did the image you posted above come from?

Kylmakalle commented 4 years ago

@ConfusedVorlon where did the image you posted above come from?

You can find mockups there - https://facebook.design/devices

ConfusedVorlon commented 4 years ago

I suspect I manually adjusted one of those images, but I can't remember. At the time, the facebook devices didn't have a suitably sized frame. Has that changed?

On Thu, 21 Nov 2019 at 19:45, JulesMoorhouse notifications@github.com wrote:

@ConfusedVorlon https://github.com/ConfusedVorlon where did the image you posted above come from?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/fastlane/frameit-frames/issues/7?email_source=notifications&email_token=AAEPJHVL5ILKMB7GYHGHDDLQU3QL5A5CNFSM4HFDWJW2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEE3NS3I#issuecomment-557242733, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEPJHQFWTLBYJP476UBL63QU3QL5ANCNFSM4HFDWJWQ .

--

Hobbyist Software is a trading name of Hobbyist Software Limited. Registered office 12 Fraley Rd, Bristol, BS93BS. Registered in England. Company no:7876492

JulesMoorhouse commented 4 years ago

When running frameIt it doesn't pickup those images shown above with he curl statement :(

If you don't need this black line (home slider) or has screenshots in landscape mode, you can use latest (29 sept 2019) device mockups from Facebook. Offset was adjusted and looks fine for me, but i'm not sure it's pixel accurate

Mockups (Space Gray & Silver)

curl https://user-images.githubusercontent.com/24507532/66273840-689ba700-e880-11e9-95e6-7ecb63728b2c.png -o ~/.fastlane/frameit/latest/Apple\ iPad\ Pro\ \(12.9-inch\)\ \(3rd\ generation\)\ Space\ Gray.png
curl https://user-images.githubusercontent.com/24507532/66273839-66394d00-e880-11e9-85cf-50f4dc0210c5.png -o ~/.fastlane/frameit/latest/Apple\ iPad\ Pro\ \(12.9-inch\)\ \(3rd\ generation\)\ Silver.png

# Remove last two lines
sed -i '' -e '$ d' ~/.fastlane/frameit/latest/offsets.json
sed -i '' -e '$ d' ~/.fastlane/frameit/latest/offsets.json
cat >> ~/.fastlane/frameit/latest/offsets.json <<EOL
    ,
      "iPad Pro (12.9-inch) (3rd generation)": {
      "offset": "+200+200",
      "width": 2048
    }
  }
}
EOL

Any further suggestions, I can’t get this to work now, it says it can’t find the 3rd gen item?

JulesMoorhouse commented 4 years ago

@ConfusedVorlon Have you ran FrameIT for this device recently?

ConfusedVorlon commented 4 years ago

@ConfusedVorlon Have you ran FrameIT for this device recently?

not a clean version of FrameIt. (I think it is using my frame at the moment)

JulesMoorhouse commented 4 years ago

OK, I've solved my problem, I think I must have had an old version of frameit installed, perhaps and uninstall and reinstall may have fixed this. However I've got some different paths, I also needed to diff my offsets file.

/Users/jm/.fastlane/frameit/latest/

~/.frameit/devices_frames_2/latest/
MakakWasTaken commented 2 years ago

If you don't need this black line (home slider) or has screenshots in landscape mode, you can use latest (29 sept 2019) device mockups from Facebook. Offset was adjusted and looks fine for me, but i'm not sure it's pixel accurate

Mockups (Space Gray & Silver)

curl https://user-images.githubusercontent.com/24507532/66273840-689ba700-e880-11e9-95e6-7ecb63728b2c.png -o ~/.fastlane/frameit/latest/Apple\ iPad\ Pro\ \(12.9-inch\)\ \(3rd\ generation\)\ Space\ Gray.png
curl https://user-images.githubusercontent.com/24507532/66273839-66394d00-e880-11e9-85cf-50f4dc0210c5.png -o ~/.fastlane/frameit/latest/Apple\ iPad\ Pro\ \(12.9-inch\)\ \(3rd\ generation\)\ Silver.png

# Remove last two lines
sed -i '' -e '$ d' ~/.fastlane/frameit/latest/offsets.json
sed -i '' -e '$ d' ~/.fastlane/frameit/latest/offsets.json
cat >> ~/.fastlane/frameit/latest/offsets.json <<EOL
    ,
   "iPad Pro (12.9-inch) (3rd generation)": {
       "offset": "+200+200",
       "width": 2048
    }
  }
}
EOL

This did not work for me because frameit replaced '-' with ' ', which then leads to the program not being able to find the '12.9-inch' part of the string. Instead I used:

 curl https://user-images.githubusercontent.com/24507532/66273840-689ba700-e880-11e9-95e6-7ecb63728b2c.png -o ~/.fastlane/frameit/latest/Apple\ iPad\ Pro\ \(12.9-inch\)\ \(3rd\ generation\)\ Space\ Gray.png
 curl https://user-images.githubusercontent.com/24507532/66273839-66394d00-e880-11e9-85cf-50f4dc0210c5.png -o ~/.fastlane/frameit/latest/Apple\ iPad\ Pro\ \(12.9-inch\)\ \(3rd\ generation\)\ Silver.png

 # Remove last two lines
 sed -i '' -e '$ d' ~/.fastlane/frameit/latest/offsets.json
 sed -i '' -e '$ d' ~/.fastlane/frameit/latest/offsets.json
 cat >> ~/.fastlane/frameit/latest/offsets.json <<EOL
     ,
       "iPad Pro (12.9 inch) (3rd generation)": {
        "offset": "+120+206",
        "width": 2048
     }
   }
 }
 EOL