Updated iPad Pro images to 3rd Gen

googlebot commented 5 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

mikelrob commented 5 years ago

I signed it!

googlebot commented 5 years ago

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

janpio commented 5 years ago

Where do these images comes from @mikelrob? What is their license?

mikelrob commented 5 years ago

Images were downloaded from Apple's Market Resources Site https://developer.apple.com/app-store/marketing/guidelines/#section-products

License Info can be found at https://www.apple.com/legal/intellectual-property/guidelinesfor3rdparties.html

getaaron commented 5 years ago

Hmm, that license says Note: You must obtain express written permission from Apple before using any photograph owned or licensed by Apple. But the developer site says Use Apple-provided product images in all your marketing materials to display your app on the Apple devices it supports, so that seems like express written permission to me.

mikelrob commented 5 years ago

The usual iPad Pro images are still needed unfortunately to frame actual iPad Pro 12.9 1st and 2nd gen screenshots. We can't just overwrite those :/

It would be preferable to have all the devices available for automated screenshotting and framing, however I don't think the frameit tool in fastlane is compatible with this preference currently. Following on from @getaaron's fine research -

Use Apple-provided product images in all your marketing materials to display your app on the Apple devices it supports.

The developer site recommends: Always use the latest-generation product images for which your app is currently developed. See here The latest-generation and only available iPad Pro from Apple is the rounded Liquid Retina screen with notch as depicted in the updated image. I believe the frameit would be at it's most useful using these updated images in the PR to attempt to comply with Apple's guidelines.

mikelrob commented 5 years ago

It would be preferable to have all the devices available for automated screenshotting and framing, however I don't think the frameit tool in fastlane is compatible with this preference currently.

Apologies, I have been working with fastlane version 2.117.0. I have only recently seen the PRs https://github.com/fastlane/fastlane/pull/14576 https://github.com/fastlane/fastlane/pull/14653

janpio commented 5 years ago

No worries, it's a confusing mess what Apple created here by having the same resolution for two devices. We are trying hard to find workarounds, but it takes some time to get all the pieces to the correct place.

RSickenberg commented 5 years ago

Any update on this? :-)

janpio commented 5 years ago

@mikelrob What were the manual steps you took after downloading the images from Apple's site? Maybe we can incorporate these as an additional step to the Facebook Design frame into our frames generator.

mikelrob commented 5 years ago

@mikelrob What were the manual steps you took after downloading the images from Apple's site? Maybe we can incorporate these as an additional step to the Facebook Design frame into our frames generator.

First I had to remove the colour fill within the screen area by reducing it's alpha to zero. Then I had to resize the images manually as the the 'holes' left in the screen area were a 10 or 12 pixels too large leaving a transparent border between the bezel and the framed screen shot. Apple only provide one image and it's named Silver, some modification is need to make it look Space Grey.

janpio commented 5 years ago

Meh, that doesn't sound too good for automation on our side. Maybe the licence allows you to re-host the files on a repository of yours so we can use that one where you already did this work?

mikelrob commented 5 years ago

I'd refer back to @getaaron's fine investigative work again where he highlighted:

Use Apple-provided product images in all your marketing materials to display your app on the Apple devices it supports, so that seems like express written permission to me.

Reads to me like Apple allow developers to use their supplied image. I don't see any specific exclusions about hosting the image.

mikelrob commented 5 years ago

@janpio I have reinstated the original iPad Pro assets and added the new assets named with the disambiguation file name added to fastlane via PR https://github.com/fastlane/fastlane/pull/14576 I've also made a change to fastlane frameit to allow it to correctly identify the device type from the filename of the image it is attempting to frame, see https://github.com/fastlane/fastlane/pull/14787

jordanpichler commented 5 years ago

Any updates on this? 😁

mikelrob commented 5 years ago

No :(

getaaron commented 5 years ago

I think the only change still needed is to make the script at https://github.com/fastlane/fastlane/blob/master/frameit/frames_generator/Rakefile download the new assets from somewhere?

janpio commented 5 years ago

Download and create the offset json data automatically, yes.

ainame commented 4 years ago

https://github.com/fastlane/fastlane/issues/14713#issuecomment-555994226

JulesMoorhouse commented 4 years ago

@janpio can the images @ainame be used?

This also seems useful, buts didn't work for me... https://github.com/fastlane/frameit-frames/issues/7

joshdholtz commented 3 years ago

My apologies on not seeing this PR 😱 Going to close this since out of date but I’m keep a better on on things here now and will get future PRs merged faster 💪

fastlane / frameit-frames