fastlane / github-actions

MIT License
75 stars 7 forks source link

`fastlane-env-reminder` is delivered as a container and run with docker #19

Closed mollyIV closed 4 years ago

mollyIV commented 5 years ago

Description

Delivering fastlane-env-reminder as a container that can be run with docker will simplify the release process - no need for pushing the production dependencies 🎉 Please read more about how we release new versions here.

The next step will be releasing a new version of this action and deleting production dependencies from fastlane-env-reminder on latest branch 👍

closes https://github.com/fastlane/github-actions/issues/18

Testing

To test the changes, please specify the following in your workflow file:


name: Processing issues
on: 
  issues:
    types: [opened]

jobs:   
  fastlane-env:
    name: fastlane env reminder
    runs-on: ubuntu-latest    
    steps:
    - uses: actions/checkout@master
    - uses: mollyIV/github-actions/fastlane-env-reminder@fastlane-env-reminder-docker
      with:
        repo-token: "${{ secrets.GITHUB_TOKEN }}"

I tested the workflow on my private repository.

image

image

🎊

janpio commented 4 years ago

The general idea sounds fine - if it works I am good with merging this.

mollyIV commented 4 years ago

The general idea sounds fine - if it works I am good with merging this.

The biggest benefit of running the action in docker container is simplified release process - no need for pushing the production dependencies 🎉

Thanks for your review @janpio 🙇