search

fastly / Viceroy

Viceroy provides local testing for developers working with Compute.
https://fastly.dev/learning/compute/testing/#running-a-local-testing-server
Apache License 2.0
140 stars 35 forks source link

Update wasmtime* crates to 19.0.2 #361

Closed fgsch closed 1 month ago

fgsch commented 2 months ago

I wanted to have an idea of how much effort, at least superficially, was required to update Viceroy. The tests are passing but beyond that this is mostly mechanical and untested.

Addresses #360 and I believe is required for #357.

jameysharp commented 2 months ago

Oh, and if we want to note anything about user-visible changes in Viceroy release notes, upgrading to Wasmtime 18 or newer gets us name demangling in guest-profiler output, which is a nice quality of life improvement when profiling Rust services especially.

fgsch commented 2 months ago

[..] I'm less sure about switching from wasmtime-wasi to wasi-common. My impression is that wasi-common is becoming deprecated, but I'm not certain of that.

Thanks for having a look. I will check this and update the PR accordingly.

elliottt commented 1 month ago

Do you mind if we close this in favor of #366? I've made the wasmtime-wasi switch in that PR as well.

fgsch commented 1 month ago

Closed in favour of #366