fastly / compute-actions

GitHub Actions for building on Fastly Compute.
https://www.fastly.com/blog/introducing-github-actions-for-compute-edge-a-new-resource-to-help-ship-code
MIT License
40 stars 9 forks source link

deploy action should support --service-name param #22

Closed nodirnasirov closed 2 years ago

nodirnasirov commented 2 years ago

It would be big help if there was --service-name param support for fastly deploy action. Fastly CLI has --service-name, so It think it should not be a big change

kailan commented 2 years ago

Hi @nodirnasirov –– I'm wondering what your use case is here. From my past experience, the service name is something that would bet set once rather than upon every deployment. Are you perhaps looking to provision new services for each deployment?

nodirnasirov commented 2 years ago

so here is the use case: I have a codebase I want to deploy into multiple existing services I have setup github workflow that uses matrix of service ids and deploys them (codebase is built leveraging fastly env vars) I wanted to provide service name instead of service ids, it will make my action output more human readable. fastly compute deploy --service-name=foo does not create new service, but it deploys into existing fastly service. This feature will allow my actions matrix to become more human readable. Instead of:

 strategy:
      matrix:
        service: [
          '787....DSD', # service id(possibly 50-60 services)
        ]

it will become:

 strategy:
      matrix:
        service: [
          'my_awesome_service', # service name(possibly 50-60 services)
        ]

It will make github action output more human readable as well

nodirnasirov commented 2 years ago

When do you think this can be merged and available?

kailan commented 2 years ago

Confirmed with reporter that this is no longer a requirement via Slack, so will close the issue.

If anyone is reading this in the future because you need the same thing, feel free to leave a comment and this can be reopened :)