search

fastly / compute-actions

GitHub Actions for building on Fastly Compute.
https://www.fastly.com/blog/introducing-github-actions-for-compute-edge-a-new-resource-to-help-ship-code
MIT License
40 stars 9 forks source link

'service_id` is passed in a wrong way in 'deploy' action #3

Closed dnechay closed 3 years ago

dnechay commented 3 years ago

Hi! Thank you for this convenient GH action.

I faced small issues when tried to use it. When service_id is passed the deploy action can't handle it properly and fails:

/opt/hostedtoolcache/fastly/0.36.0/x64/fastly compute deploy -v --service-id,<passed_value>

but it should be passed as --service-id=<passed_value>

This happens because of line below: https://github.com/fastly/compute-actions/blob/main/deploy/index.js#L14

kailan commented 3 years ago

Hi @dnechay – this should be resolved now. Please let me know if you run into any further issues!