Closed mrnetops closed 1 year ago
While we're at it, can we possibly rename the vXX format that admittedly matches the fastly documentation and data structure, but absolutely does not match how anybody sane would present the data?
i.e. nobody says tls v12 rather then tls 1.2, and this leads to needless overrides when trying to present the data.
In grafana for example, I need to break it into individual queries with explicit legend overrides, or try and find other override/formatting trickery to get presentation to make sense.
https://www.google.com/search?q=tls+v12 returns 395,000 results (most of which are actually 1.2 references) https://www.google.com/search?q=tls+1.2 returns 28,900,000 results
pushed a pre-release with this change https://github.com/fastly/fastly-exporter/releases/tag/v8.0.0-beta
@mrnetops This is officially released (at last): https://github.com/fastly/fastly-exporter/releases/tag/v8.0.0
This is essentially including a total field in the metric itself which is violates
Per https://prometheus.io/docs/practices/naming/
As this essentially means that a simple
sum(rate(fastly_rt_tls_total[1m])) by (service_name)
ends up double counting the values (v10 + v11 + v12 + v13 + any) as seen in this normalized snippetWe shouldn't be adding any total or sum subvalue that will impact totaling or summing the metric itself.