fastly / fastly-exporter

A Prometheus exporter for the Fastly Real-time Analytics API
Apache License 2.0
99 stars 36 forks source link

metric consolidation for http2/http3 #122

Closed mrnetops closed 1 year ago

mrnetops commented 1 year ago

Similar to how we consolidated

We should consolidate

Right now we need to do hinky things like

sum(rate(fastly_rt_requests_total{}[1m])) 
- sum(rate(fastly_rt_http2_total{}[1m]))
- sum(rate(fastly_rt_http3_total{}[1m])) 

to derive http1 requests and it requires us to explicitly know every potential metric name in play to essentially derive it by exclusion.

i.e. if http4 is added, the above exclusion calculation breaks unless it is explicitly adjusted.

fastly_rt_http_total {version=1} would be soooo much nicer and way less fragile.