search

fastly / fastly-exporter

A Prometheus exporter for the Fastly Real-time Analytics API
Apache License 2.0
99 stars 36 forks source link

Refactor labels used in realtime package #167

Closed mikelorant closed 5 months ago

mikelorant commented 6 months ago

Previously, each metric had a static list of labels to be applied. By changing this to a variable, we can now define a default set of labels plus any extra labels.

These changes are preparation work for introducing a feature allowing for the removal of the datacenter label.

mikelorant commented 6 months ago

@leklund Taking a different approach of smaller pull requests working towards the feature of being able to remove the datacenter label. This should significantly help with reducing the size of the next pull request and hopefully speed up the approval process.

mikelorant commented 6 months ago

If you are happy with these results, I will put up 2 more pull requests to refactor the domain and origin packages to use the same approach.

mikelorant commented 6 months ago

Branches for:

leklund commented 5 months ago

@mikelorant This can be closed, correct?

mikelorant commented 5 months ago

Closing this one as an alternative approach was taken in #169.