search

fastly / fastly-magento2

Module for integrating Fastly CDN with Magento 2 installations
BSD 3-Clause "New" or "Revised" License
145 stars 119 forks source link

Bug on Fastly module UI #682

Closed ikhadka closed 8 months ago

ikhadka commented 8 months ago

Hello Fastly Team,

Multiple customers are raising this issue as a bug.

Unable to add log shipping jobs due to a bug on Fastly Magento UI that is not saving

When we add the condition and create it is not saving.

Steps to Reproduce: stores>configuration> advanced > system > tools> attach condition > create new response condition> name and give logic > click create > create go back onto it condition is missing

Customer is on the following fastly module version:

1.2.210

Please note this issue is with fastly module so please investigate this from your side.

Customer is on fastly magento issue (2)

Thanks Ishwar

dpotkoc commented 8 months ago

Hello @ikhadka I will really appreciate if you can test PR https://github.com/fastly/fastly-magento2/pull/683

Thnx in advance

ikhadka commented 8 months ago

Hello @dpotkoc

Thanks Sure I will request fastly team to test this.

Thanks Ishwar

ikhadka commented 8 months ago

Hello @dpotkoc

Just wondering have you pushed the change to a new fastly module version ?

Thanks Ishwar

vvuksan commented 8 months ago

Hi @ikhadka,

We have not merged this request. If you are able to confirm that this fix works we can merge it immediately.

Thanks

ikhadka commented 8 months ago

Hello @vvuksan

Thank you for getting back to me here. I don't have the correct level of access to test this from my side and we may need to wait till Monday to test this.

Thanks Ishwar

ikhadka commented 8 months ago

Hello @vvuksan @dpotkoc

Thank you for looking in to to this and we have tested this new code and this works. Please could you push the change to live. Also do let me know the module version customer needs to upgrade to see the new change Thanks

vvuksan commented 8 months ago

Fixed in 1.2.211.