Fix: Run build against PHP7

fastly / fastly-php

A Fastly API client for PHP

https://packagist.org/packages/fastly/fastly

MIT License

24 stars 34 forks source link

Fix: Run build against PHP7 #21

Closed localheinz closed 8 years ago

localheinz commented 8 years ago

This PR

[x] adds PHP 7 to the build matrix

Related to #20.

thommahoney commented 8 years ago

@localheinz I honestly don't know enough PHP to fix this test failure in PHP7 but it has to do with the argument list and the testing framework that is used in this library. If you can fix it then great, but there is no expectation for you to do so.

localheinz commented 8 years ago

@thommahoney

This is related to using an outdated version of phpspec, I think, looking into it.

For reference, see for example https://github.com/phpspec/phpspec/issues/659.

thommahoney commented 8 years ago

Let's see if rebasing this over master fixes the failures on PHP 7.

localheinz commented 8 years ago

@thommahoney

👍