Enhancement: Use friendsofphp/php-cs-fixer to enforce PSR-2

fastly / fastly-php

A Fastly API client for PHP

https://packagist.org/packages/fastly/fastly

MIT License

24 stars 34 forks source link

Enhancement: Use friendsofphp/php-cs-fixer to enforce PSR-2 #24

Closed localheinz closed 4 years ago

localheinz commented 8 years ago

This PR

[x] requires friendsofphp/php-cs-fixer
[x] adds a simple configuration for php-cs-fixer, requiring code to comply with PSR-2
[x] runs php-cs-fixer on Travis
[x] adds a cs script to composer.json
[x] runs composer cs
[x] adds a CONTRIBUTING.md with instructions

💁 For reference, see https://github.com/FriendsOfPHP/PHP-CS-Fixer.

thommahoney commented 8 years ago

I would be interested to see a style guide included in this repo instead of dotfiles for editor configuration. I know that my editor (vim) would not respect this config. At fastly we avoid checking dotfiles into our repos for this reason.

localheinz commented 8 years ago

@thommahoney

How about using friendsofphp/php-cs-fixer or squizlabs/php_codesniffer?

localheinz commented 8 years ago

@thommahoney

Not sure if you've received GitHub notifications, but I have updated this PR to use friendsofphp/php-cs-fixer to enforce coding standards. This is probably also the better choice as with phpspec/phpspec, squizlabs/php_codesniffer will complain a lot about using snake_case for method names, and requires custom configuration.