search

fastly / fastly-php

A Fastly API client for PHP
https://packagist.org/packages/fastly/fastly
MIT License
24 stars 34 forks source link

Support for PHP 8 and avoiding the PHP Deprecated Warning #42

Closed Integralist closed 1 year ago

Integralist commented 2 years ago

Version

Local dev build from internal repo.

What happened

Running composer test would show:

PHP Deprecated:  Return type of Fastly\Model\ServiceListResponse::offsetExists($offset) should either be compatible with ArrayAccess::offsetExists(mixed $offset): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /Users/integralist/Code/fastly/api-clients-generator/fastly-php/lib/Model/ServiceListResponse.php on line 536
Integralist commented 2 years ago

A quick Google returned this: https://stackoverflow.com/questions/71133749/reference-return-type-of-should-either-be-compatible-with-or-the-re

Integralist commented 1 year ago

Closing this issue now we've published v1.0.0 https://packagist.org/packages/fastly/fastly