search

fastly / fastly-py

A Fastly API client for Python
https://pypi.org/project/fastly/
MIT License
77 stars 60 forks source link

Adds user agent to query headers #25

Closed gschorkopf closed 8 years ago

gschorkopf commented 8 years ago

Issues:

>>> from fastly._version import __version__
>>> __version__
'0.1.1'

Which seems to work OK in that context.

Risk:

thommahoney commented 8 years ago

This looks good to me.

blithe commented 8 years ago

I'd love to see a test that asserts the value of the header.

drbrain commented 8 years ago

We should increment the version to 0.2.0 because the User-Agent header is a new feature.

gschorkopf commented 8 years ago

I was under the impression we do that after the PR is accepted @drbrain?

blithe commented 8 years ago

Merging this as is and we can bump the version on master.