fastly / fastly-py

A Fastly API client for Python
https://pypi.org/project/fastly/
MIT License
77 stars 59 forks source link

Generic way to get collection lists, plus general expansion of API support. #30

Closed dcmoore-gd closed 6 years ago

dcmoore-gd commented 7 years ago

This incorporates changes from:

@djworth's PR #22 (with conflicts resolved) @lisac's PR #29

Plus some, and adds in some additional methods.

lisac commented 7 years ago

this looks really cool, @dcmoore-gd ! And thanks for incorporating my PR, too. :) @thommahoney - would you have time to review this? I noticed the last commits on master are yours... or could you recommend someone who could do the review? thanks.

dcmoore-gd commented 7 years ago

And thank you @lisac for writing the list method!

dcmoore-gd commented 6 years ago

Whoa! @psbanka is Fastly supporting this again? Last we talked to them it was officially abandoned. I'm hoping that's changed!

davy commented 6 years ago

We have always strived to incorporate useful contributions within a timely manner, but sometimes we've been better at this goal than others. We are glad @psbanka is now helping us improve in this area by keeping a closer eye on contributions to fastly-py from the community! 🎉

dcmoore-gd commented 6 years ago

BTW @davy I didn't mean to imply anything negative! I'd asked our Fastly rep and they'd said it wouldn't be supported anymore. We're just happy that's changed! Thanks!