search

fastly / fastly-py

A Fastly API client for Python
https://pypi.org/project/fastly/
MIT License
77 stars 59 forks source link

Implements purging by keys in a batch #48

Closed stanimoto closed 4 years ago

stanimoto commented 4 years ago

Hello!

Any chances that this can get merged or could I get some feedback?

Thanks!

annawinkler commented 4 years ago

Hi @stanimoto ! Thank you for your PR! I will take a look 👀 and let you know.

annawinkler commented 4 years ago

It sounds like we will want to add a doc PR to update the docs here https://docs.fastly.com/api/purge#purge_db35b293f8a724717fcf25628d713583 @psbanka

stanimoto commented 4 years ago

It sounds like we will want to add a doc PR to update the docs here https://docs.fastly.com/api/purge#purge_db35b293f8a724717fcf25628d713583 @psbanka

Hi @annawinkler and @psbanka ! The docs seem good to me, but please let me know if I can do anything!

iffius commented 4 years ago

@annawinkler @psbanka This PR seems to be languishing. It's useful and provides parity with the API documentation (listed previously). Is there anything we can do to get this PR to a place where it can be merged?

annawinkler commented 4 years ago

@iffius Apologies for the delay and we appreciate your patience. I'll see what we can do in the next week.

psbanka commented 4 years ago

Hey, @iffius — I have thoroughly tested these changes, and they look great. Will merge your PR. Sorry for the delay!

stanimoto commented 4 years ago

Thank you @annawinkler @psbanka for reviewing and @iffius for urging. :)