fastly / ftw

Framework for Testing WAFs (FTW!)
Apache License 2.0
264 stars 58 forks source link

Adds port and protocol command line options #85

Closed bclodius closed 7 years ago

bclodius commented 7 years ago

This PR supports port and protocol command line options to easily reuse large test suites without having to modify all the yaml files.

@csanders-git @zmallen

zmallen commented 7 years ago

hi there!

Thanks for the commit. Ill be looking into this today/tomorrow. Dont worry about travis failing -- those tests are fixed in a separate P/R

bclodius commented 7 years ago

@zmallen thanks! Looking forward to your review/feedback.

zmallen commented 7 years ago

this is blocked by #84 which @csanders-git should be merging tonight (nudge nudge). I'll ping on here for you to rebase with master once #84 is merged then tests should pass.

zmallen commented 7 years ago

hi @bclodius can you rebase with master? ill merge this in and do a pip release tonight

bclodius commented 7 years ago

@zmallen due to a mistake on my side with git history; I'll resubmit this on another PR.

zmallen commented 7 years ago

ACK, thx