add origin_fetch_resp_*_bytes in Stats struct

fastly / go-fastly

A Fastly API client for Go

https://pkg.go.dev/github.com/fastly/go-fastly

Apache License 2.0

156 stars 126 forks source link

add origin_fetch_resp_*_bytes in Stats struct #548

Closed kartheekkaipa closed 1 month ago

kartheekkaipa commented 1 month ago

Currently go-fastly do not have field for bytes fetched from origin for Stats response for GetStatsField function.

origin_fetch_resp_body_bytes
origin_fetch_resp_header_bytes

File: fastly/stats_historical.go

if it's okay, I will raise the PR for the change.

kpfleming commented 1 month ago

Indeed, those are documented here and here. A PR would be very welcome!

kartheekkaipa commented 1 month ago

I will start with changes.

I am getting 404 for the above links, can you please check the same.

Thank you

kpfleming commented 1 month ago

Oh, sorry, those were internal links, my apologies!

The public documentation for those fields is here.

Take a look at the CONTRIBUTING and TESTING files to understand what you'll need to do to enhance the existing test fixtures to support those new fields.

Jelmund commented 1 month ago

I opened a PR for this issue at: https://github.com/fastly/go-fastly/pull/552