search

fastly / js-compute-runtime

JavaScript SDK and runtime for building Fastly Compute applications
https://developer.fastly.com/learning/compute/javascript/
Apache License 2.0
193 stars 26 forks source link

feat: Allow early logger initialization #804

Closed guybedford closed 2 weeks ago

guybedford commented 2 weeks ago

This resolves https://github.com/fastly/js-compute-runtime/issues/225 in supporting lazy initialization of the logging endpoint allowing the logger to be created during preinitialization.

LeslieCarr commented 2 weeks ago

@jaskiratr

guybedford commented 2 weeks ago

Looking into this further, it seems Viceroy does handle the logging to stdout as I would have expected, so this PR actually causes a double log when --verbose is set.

Instead I'm just going to refactor this to not do the stdout logging and just be a fix for #225.

guybedford commented 2 weeks ago

I've updated this PR title and description to just be a fix for #225.