fastly / pushpin

A proxy server for adding push to your API, used at the core of Fastly's Fanout service
https://pushpin.org
Apache License 2.0
3.66k stars 153 forks source link

Config value not passed down (push_in_http_max_body_size) #48084

Open TKone7 opened 1 week ago

TKone7 commented 1 week ago

In #47691 a new config parameter was added to configure the maximum allowed size of an http body when publishing data (push_in_http_max_body_size).

After tweaking this value I did not see any difference in behavior.

Although I am not aware of the project's structure I think I might have found the place where the config value is "lost". In src/handler/handlerapp.cpp the config name is wrongly used as push_in_max_body_size instead of push_in_http_max_body_size. If I set the push_in_max_body_size config in my pushpin.conf I see the expected behavior.