fastmachinelearning / hls4ml

Machine learning on FPGAs using HLS
https://fastmachinelearning.org/hls4ml
Apache License 2.0
1.29k stars 419 forks source link

remove incorrect setting of result_t #1130

Closed jmitrevs closed 1 week ago

jmitrevs commented 1 week ago

Description

The result_t was incorrect set in the MergeLinearActivation optimizer. This removes the setting, which wasn't needed anyway. Setting get_output_variable().type.precision already sets it properly as a side-effect.

Type of change

Tests

This fixes a bug found in #1122. The test is there.

Checklist

jmitrevs commented 1 week ago

A few more optimizers also needlessly (and incorrectly) set result_t, so I removed those, too.