fastmachinelearning / hls4ml

Machine learning on FPGAs using HLS
https://fastmachinelearning.org/hls4ml
Apache License 2.0
1.22k stars 396 forks source link

Fix incorrectly linted build() command #709

Closed vloncar closed 1 year ago

vloncar commented 1 year ago

Description

Recent reformatting of the code changed the build command in build() of vivado_backend.py. The multi-line string is missing spaces between the parameters. The following error happens:

---------error message---------
Sourcing Tcl script 'build_prj.tcl'
expected boolean value but got "Falsecsim"
    while executing
"if {$opt(reset)} {
    open_project -reset ${project_name}_prj
} else {
    open_project ${project_name}_prj
}"
    (file "build_prj.tcl" line 149)
    invoked from within
"source build_prj.tcl"
    ("uplevel" body line 1)
    invoked from within
"uplevel \#0 [list source $arg] "

Hopefully the linter doesn't complain about this.

Type of change

Tests

The Jenkins tests should prove that this works.

Checklist