Closed vloncar closed 1 year ago
@jmduarte @vloncar Feel free to use the model above as test if it's useful, but it might have other issues down the line :)
I would add the deep sets-like model in the example-models
repository, this is something we don't have and it is a useful demonstration. Do we have a reasonable model at hand?
Description
When creating PointwiseConv layers we always expand dimensions of weights to
(1, 1, x, y)
, but in 1d we should only expand to(1, x, y)
. This breaks some model Thea is using.Type of change
Tests
From Thea:
Note that there is a misparse due to a
keepdims
argument not being supported in GlobalPooling layer. I'll push a PR for that as well.Checklist
I can't run
pre-commit
due to a strange bug so this will probably fail the test, but I'll fix that afterwards.