fastmachinelearning / hls4ml

Machine learning on FPGAs using HLS

https://fastmachinelearning.org/hls4ml

Apache License 2.0

1.24k stars 402 forks source link

Fixed sign parsing for ac_fixed and ac_int #727

Closed jmitrevs closed 1 year ago

jmitrevs commented 1 year ago

Description

Previously 'ac_fixed<..>' and 'ac_int<..>' strings in the configuration were always parsed as signed. This fixes the issue

Type of change

[x] Bug fix (non-breaking change that fixes an issue)

Tests

I added a pytest to just directly call convert_precision_string and make sure that signed was correctly evaluated

Checklist

[x] I have read the guidelines for contributing.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have made corresponding changes to the documentation.
[x] My changes generate no new warnings.
[x] I have installed and run pre-commit on the files I edited or added.
[x] I have added tests that prove my fix is effective or that my feature works.

jmitrevs commented 1 year ago

I seem to have trouble initiating CI. Any suggestion?