fastmachinelearning / hls4ml

Machine learning on FPGAs using HLS
https://fastmachinelearning.org/hls4ml
Apache License 2.0
1.17k stars 388 forks source link

[pre-commit.ci] pre-commit autoupdate #796

Closed pre-commit-ci[bot] closed 1 year ago

pre-commit-ci[bot] commented 1 year ago

updates:

jmitrevs commented 1 year ago

What do people think. Do we merge this? The removal of blank lines may cause some conflicts.

jmduarte commented 1 year ago

Seems fine to me.

jmitrevs commented 1 year ago

Do you know why the spacing changed?

Anyway, unless anyone objects while I am out for lunch I'll merge after.

jmduarte commented 1 year ago

Yeah, it's a good question. I think this is from black 22 -> 23 (but I could've swore I updated black to 23 earlier.. although looking at this update clearly that's not the case).

vloncar commented 1 year ago

I liked some of those empty lines :cry:. they brought clarity in the long functions, like in the writer and parts of backend.

jmitrevs commented 1 year ago

Truthfully it's only in a few places where it removes lines. I don't think it's too bad. I'll go ahead and merge it.