fastmachinelearning / hls4ml

Machine learning on FPGAs using HLS
https://fastmachinelearning.org/hls4ml
Apache License 2.0
1.24k stars 402 forks source link

separable conv fixes #849

Closed rkovachfuentes closed 1 year ago

rkovachfuentes commented 1 year ago

A# Description

minimal changes to allow QSeparableConv2D with hls4ml

Type of change

For a new feature or function, please create an issue first to discuss it with us before submitting a pull request.

Note: Please delete options that are not relevant.

Tests

tried to compile a model with QSeparableConv2D layers - it did not work before, it works now

Test Configuration:

Checklist

vloncar commented 1 year ago

Thanks for this. Can you add a unit test?

jmitrevs commented 1 year ago

@rkovachfuentes, in the test/pytest/test_qkeras.py file (or the test/pytest/test_seqconv2d.py file) it should be pretty easy to add a test for QSeparableConv2D--basically copy and slightly modify test_sepconv2d from test_sepconv2d.py.

vloncar commented 1 year ago

Continued in #861, closing.